Implement update team endpoint (TS-2314) #1116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Roffenlund
commented
Mar 17, 2025
•
Roffenlund
commented
- Implement and endpoint in cyberstorm api for updating teams
- Support only updating donation_link for now
- Implement tests
- Implement service layer function for updating teams, and implement tests
- Use the service layer function in the form view responsible for updating team donation links
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Roffenlund
force-pushed
the
cyberstorm-api-update-team
branch
3 times, most recently
from
015f8b1 to
d0b7f20
Compare
x753
approved these changes
Mar 18, 2025
Implement service layer function for updating teams. Support only dontation_link at the moment. Implement tests. Refs. TS-2314
Refs. TS-2314
Roffenlund
force-pushed
the
cyberstorm-api-update-team
branch
from
d0b7f20 to
dfc0a3b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1116 +/- ##
==========================================
- Coverage 93.02% 93.01% -0.01%
==========================================
Files 324 324
Lines 9685 9709 +24
Branches 858 859 +1
==========================================
+ Hits 9009 9031 +22
- Misses 554 555 +1
- Partials 122 123 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MythicManiac
reviewed
May 8, 2025
|
Also as noted in #1117 (comment), I suspect the service layer functionality should be called from within the form class implementation instead of the view |
Roffenlund
force-pushed
the
cyberstorm-api-update-team
branch
from
dfc0a3b to
1f21881
Compare
Implement APIView for updating teams. Currently support only dontation_link over PATCH request. Add URl and update tests. Refs. TS-2314
Roffenlund
force-pushed
the
cyberstorm-api-update-team
branch
from
1f21881 to
589b136
Compare
Roffenlund
requested review from
MythicManiac
and removed request for
x753 and
Oksamies
Roffenlund
force-pushed
the
cyberstorm-api-update-team
branch
from
589b136 to
15f11fb
Compare
Roffenlund
force-pushed
the
cyberstorm-api-update-team
branch
2 times, most recently
from
d191a37 to
9d657af
Compare
MythicManiac
reviewed
May 9, 2025
Roffenlund
force-pushed
the
cyberstorm-api-update-team
branch
from
9d657af to
e77dca3
Compare
Use the service layer function in the form responsible for updating team's donation_links. Utilize the service layer function in the form's save function and update the view accordingly. In order to invoke the post-validation errors added to the form in the form tests, call form.save() in the tests as well. Implement tests for the view in a similar manner as they are implemented for the forms to assert functionality. Refs. TS-2314
Roffenlund
force-pushed
the
cyberstorm-api-update-team
branch
from
e77dca3 to
595edfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.