Implement delete team member endpoint(TS-2315) #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Roffenlund
commented
Mar 17, 2025
•
Roffenlund
commented
- Implement endpoint in cyberstorm api for deleting team members
- Implement service layer function
- User service layer function in the form views responsible for removing team members
- Update forms
- Update existing tests
- Implement tests
x753
reviewed
Mar 17, 2025
Roffenlund
force-pushed
the
cyberstorm-api-delete-team-member
branch
from
3eb3759 to
0c7eaad
Compare
x753
approved these changes
Mar 18, 2025
Implement a service layer function for removing a member from a team. Implent tests for the service layer function. Refs. TS-2315
Roffenlund
force-pushed
the
cyberstorm-api-delete-team-member
branch
from
0c7eaad to
ae1f556
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1118 +/- ##
==========================================
+ Coverage 93.02% 93.03% +0.01%
==========================================
Files 324 324
Lines 9685 9702 +17
Branches 858 859 +1
==========================================
+ Hits 9009 9026 +17
Misses 554 554
Partials 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Implement a APIView for removing team members from teams in the cyberstom API. Utilize the service layer function for removing team members in the view. Add URL and implement tests. Refs. TS-2315
Roffenlund
force-pushed
the
cyberstorm-api-delete-team-member
branch
2 times, most recently
from
a6d3db1 to
ab184d3
Compare
MythicManiac
requested changes
May 8, 2025
x753
reviewed
May 8, 2025
Utilize the service layer function for removing team members in the form views responsible for kicking members from a team, and in the form responsible for leaving a team. Update tests accordingly to the new changes. Remove redundant get_team_or_404 function. Refs. TS-2315
Roffenlund
force-pushed
the
cyberstorm-api-delete-team-member
branch
from
ab184d3 to
a9de63c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.