User service layer in team update form view

Use the service layer function in the form responsible for updating
team's donation_links. Utilize the service layer function in the form's
save function and update the view accordingly.

In order to invoke the post-validation errors added to the form in the
form tests, call form.save() in the tests as well.

Implement tests for the view in a similar manner as they are implemented
for the forms to assert functionality.

Refs. TS-2314

Author: Roffenlund

django/thunderstore/repository/forms/team.py

@@ -4,6 +4,7 @@
 from django.contrib.auth import get_user_model
 from django.core.exceptions import ObjectDoesNotExist, ValidationError
 
+from thunderstore.api.cyberstorm.services.team import update_team
 from thunderstore.core.exceptions import PermissionValidationError
 from thunderstore.core.types import UserType
 from thunderstore.repository.models import (
@@ -183,10 +184,20 @@ def __init__(self, user: UserType, *args, **kwargs):
     def clean(self):
         if not self.instance.pk:
             raise ValidationError("Missing team instance")
-        self.instance.ensure_user_can_edit_info(self.user)
         return super().clean()
 
     @transaction.atomic
     def save(self, **kwargs):
-        self.instance.ensure_user_can_edit_info(self.user)
-        return super().save(**kwargs)
+        if self.errors:
+            raise ValidationError(self.errors)
+
+        try:
+            update_team(
+                agent=self.user,
+                team=self.instance,
+                donation_link=self.cleaned_data["donation_link"],
+            )
+        except ValidationError as e:
+            self.add_error(None, e)
+
+        return self.instance

django/thunderstore/repository/tests/test_team_forms.py

@@ -1,6 +1,7 @@
 from typing import Optional
 
 import pytest
+from django.core.exceptions import ValidationError
 
 from conftest import TestUserTypes
 from thunderstore.core.factories import UserFactory
@@ -552,8 +553,11 @@ def test_form_donation_link_team_form_permissions(
         team.refresh_from_db()
         assert team.donation_link == link
     else:
+        form.save()
         assert form.is_valid() is False
         assert form.errors
+        team.refresh_from_db()
+        assert team.donation_link is None
 
 
 @pytest.mark.django_db

django/thunderstore/repository/tests/test_views.py

@@ -478,6 +478,62 @@ def test_team_settings_donation_link_view(
     assert b"Donation link saved" in response.content
 
 
+@pytest.mark.django_db
+@pytest.mark.parametrize("user_type", TestUserTypes.options())
+@pytest.mark.parametrize("role", TeamMemberRole.options() + [None])
+def test_team_settings_donation_link_view_permissions(
+    client: APIClient,
+    community_site: CommunitySite,
+    team: Team,
+    user_type: str,
+    role: Optional[str],
+) -> None:
+    valid_user_type_map = {
+        TestUserTypes.no_user: False,
+        TestUserTypes.unauthenticated: False,
+        TestUserTypes.regular_user: True,
+        TestUserTypes.deactivated_user: False,
+        TestUserTypes.service_account: False,
+        TestUserTypes.site_admin: True,
+        TestUserTypes.superuser: True,
+    }
+
+    valid_role_map = {
+        None: False,
+        TeamMemberRole.member: False,
+        TeamMemberRole.owner: True,
+    }
+
+    user = TestUserTypes.get_user_by_type(user_type)
+    if role is not None and user_type not in TestUserTypes.fake_users():
+        TeamMember.objects.create(user=user, team=team, role=role)
+        client.force_login(user)
+
+    should_succeed = all(
+        (
+            valid_user_type_map[user_type],
+            valid_role_map[role],
+        )
+    )
+
+    kwargs = {"name": team.name}
+    response = client.post(
+        reverse("settings.teams.detail.donation_link", kwargs=kwargs),
+        {"donation_link": "https://example.org/"},
+        HTTP_HOST=community_site.site.domain,
+        follow=True,
+    )
+
+    if should_succeed:
+        assert b"Donation link saved" in response.content
+        team.refresh_from_db()
+        assert team.donation_link == "https://example.org/"
+    else:
+        assert b"Donation link saved" not in response.content
+        team.refresh_from_db()
+        assert team.donation_link is None
+
+
 @pytest.mark.django_db
 @pytest.mark.parametrize("user_type", TestUserTypes.options())
 def test_view_package_detail_management_option_visibility_without_team(

django/thunderstore/repository/views/team_settings.py

@@ -16,6 +16,7 @@
     CreateServiceAccountForm,
     DeleteServiceAccountForm,
 )
+from thunderstore.api.cyberstorm.services.team import update_team
 from thunderstore.core.mixins import RequireAuthenticationMixin
 from thunderstore.core.utils import capture_exception
 from thunderstore.frontend.views import SettingsViewMixin
@@ -26,7 +27,6 @@
     DonationLinkTeamForm,
     EditTeamMemberForm,
     RemoveTeamMemberForm,
-    TeamMemberRole,
 )
 from thunderstore.repository.models import Team, TeamMember, reverse
 
@@ -276,5 +276,8 @@ def get_success_url(self):
         return self.object.donation_link_url
 
     def form_valid(self, form: DonationLinkTeamForm):
+        self.object = form.save()
+        if form.errors:  # Check if service layer raised an error
+            return super().form_invalid(form)
         messages.success(self.request, "Donation link saved")
-        return super().form_valid(form)
+        return redirect(self.get_success_url())