Implement update team endpoint

* Implement and endpoint in cyberstorm api for updating teams
* Support only updating donation_link for now
* Implement tests

Refs TS-2314

Author: Roffenlund

django/thunderstore/api/cyberstorm/serializers/__init__.py

@@ -11,6 +11,7 @@
     CyberstormTeamAddMemberResponseSerializer,
     CyberstormTeamMemberSerializer,
     CyberstormTeamSerializer,
+    CyberstormTeamUpdateSerializer,
 )
 
 __all__ = [
@@ -25,4 +26,5 @@
     "CyberstormTeamMemberSerializer",
     "CyberstormTeamSerializer",
     "PackagePermissionsSerializer",
+    "CyberstormTeamUpdateSerializer",
 ]

django/thunderstore/api/cyberstorm/serializers/team.py

@@ -1,5 +1,6 @@
 from typing import Optional
 
+from django.core.validators import URLValidator
 from rest_framework import serializers
 from rest_framework.exceptions import ValidationError
 
@@ -67,3 +68,9 @@ def validate(self, attrs):
         if getattr(user, "service_account", None) is not None:
             raise ValidationError("Service accounts cannot create teams")
         return attrs
+
+
+class CyberstormTeamUpdateSerializer(serializers.Serializer):
+    donation_link = serializers.CharField(
+        max_length=1024, validators=[URLValidator(["https"])]
+    )

django/thunderstore/api/cyberstorm/tests/test_team.py

@@ -318,3 +318,131 @@ def test_team_member_add_api_view__when_adding_a_member__fails_because_user_is_n
         .count()
         == 0
     )
+
+
+@pytest.mark.django_db
+def test_team_update__donation_link__succeeds(
+    api_client: APIClient,
+    user: UserType,
+    team: Team,
+):
+    TeamMemberFactory(team=team, user=user, role="owner")
+    api_client.force_authenticate(user)
+
+    new_donation_link = "https://example.com"
+
+    response = api_client.patch(
+        f"/api/cyberstorm/team/{team.name}/update/",
+        json.dumps({"donation_link": new_donation_link}),
+        content_type="application/json",
+    )
+
+    assert response.status_code == 200
+    response_json = response.json()
+    assert response_json["donation_link"] == new_donation_link
+    assert Team.objects.get(pk=team.pk).donation_link == new_donation_link
+
+
+@pytest.mark.django_db
+def test_team_update__donation_link__fails_because_user_is_not_authenticated(
+    api_client: APIClient,
+    team: Team,
+):
+    new_donation_link = "https://example.com"
+
+    response = api_client.patch(
+        f"/api/cyberstorm/team/{team.name}/update/",
+        json.dumps({"donation_link": new_donation_link}),
+        content_type="application/json",
+    )
+
+    assert response.status_code == 401
+    response_json = response.json()
+    assert response_json["detail"] == "Authentication credentials were not provided."
+    assert Team.objects.get(pk=team.pk).donation_link is None
+
+
+@pytest.mark.django_db
+def test_team_update__donation_link__fails_validation(
+    api_client: APIClient,
+    user: UserType,
+    team: Team,
+):
+    TeamMemberFactory(team=team, user=user, role="owner")
+    api_client.force_authenticate(user)
+
+    new_bad_donation_link = "example.com"
+
+    response = api_client.patch(
+        f"/api/cyberstorm/team/{team.name}/update/",
+        json.dumps({"donation_link": new_bad_donation_link}),
+        content_type="application/json",
+    )
+
+    assert response.status_code == 400
+    response_json = response.json()
+    assert "Enter a valid URL." in response_json["donation_link"]
+
+
+@pytest.mark.django_db
+def test_team_update__donation_link__fails_because_user_is_not_owner(
+    api_client: APIClient,
+    user: UserType,
+    team: Team,
+):
+    TeamMemberFactory(team=team, user=user, role="member")
+    api_client.force_authenticate(user)
+
+    new_donation_link = "https://example.com"
+
+    response = api_client.patch(
+        f"/api/cyberstorm/team/{team.name}/update/",
+        json.dumps({"donation_link": new_donation_link}),
+        content_type="application/json",
+    )
+
+    assert response.status_code == 403
+    response_json = response.json()
+    assert response_json["detail"] == "Must be an owner to edit team info"
+    assert Team.objects.get(pk=team.pk).donation_link is None
+
+
+@pytest.mark.django_db
+def test_team_update__donation_link__fails_because_team_doesnt_exist(
+    api_client: APIClient,
+    user: UserType,
+):
+    api_client.force_authenticate(user)
+
+    new_donation_link = "https://example.com"
+
+    response = api_client.patch(
+        "/api/cyberstorm/team/FakeTeam/update/",
+        json.dumps({"donation_link": new_donation_link}),
+        content_type="application/json",
+    )
+
+    assert response.status_code == 404
+    assert response.json()["detail"] == "Not found."
+
+
+@pytest.mark.django_db
+def test_team_update__donation_link__fails_because_user_not_team_member(
+    api_client: APIClient,
+    user: UserType,
+    team: Team,
+):
+    api_client.force_authenticate(user)
+
+    new_donation_link = "https://example.com"
+
+    response = api_client.patch(
+        f"/api/cyberstorm/team/{team.name}/update/",
+        json.dumps({"donation_link": new_donation_link}),
+        content_type="application/json",
+    )
+
+    expected_response = {"detail": "You do not have permission to access this team."}
+
+    assert response.status_code == 403
+    assert response.json() == expected_response

django/thunderstore/api/cyberstorm/views/__init__.py

@@ -24,6 +24,7 @@
     TeamMemberAddAPIView,
     TeamMemberListAPIView,
     TeamServiceAccountListAPIView,
+    UpdateTeamAPIView,
 )
 
 __all__ = [
@@ -49,4 +50,5 @@
     "UpdatePackageListingCategoriesAPIView",
     "RejectPackageListingAPIView",
     "ApprovePackageListingAPIView",
+    "UpdateTeamAPIView",
 ]

django/thunderstore/api/cyberstorm/views/team.py

@@ -6,6 +6,7 @@
     DestroyAPIView,
     ListAPIView,
     RetrieveAPIView,
+    UpdateAPIView,
     get_object_or_404,
 )
 from rest_framework.permissions import IsAuthenticated
@@ -21,6 +22,7 @@
     CyberstormTeamAddMemberResponseSerializer,
     CyberstormTeamMemberSerializer,
     CyberstormTeamSerializer,
+    CyberstormTeamUpdateSerializer,
 )
 from thunderstore.api.ordering import StrictOrderingFilter
 from thunderstore.api.utils import (
@@ -155,3 +157,31 @@ def check_permissions(self, request):
     )
     def delete(self, request, *args, **kwargs):
         return super().delete(request, *args, **kwargs)
+
+
+class UpdateTeamAPIView(TeamPermissionsMixin, UpdateAPIView):
+    queryset = Team.objects.filter(is_active=True)
+    lookup_url_kwarg = "team_name"
+    lookup_field = "name"
+    serializer_class = CyberstormTeamUpdateSerializer
+    http_method_names = ["patch"]
+
+    def check_permissions(self, request):
+        super().check_permissions(request)
+        team = self.get_object()
+        team.ensure_user_can_edit_info(self.request.user)
+
+    def perform_update(self, serializer):
+        instance = serializer.instance
+        instance.donation_link = serializer.validated_data["donation_link"]
+        instance.save()
+
+    @conditional_swagger_auto_schema(
+        operation_id="cyberstorm.team.update",
+        tags=["cyberstorm"],
+        request_body=CyberstormTeamUpdateSerializer,
+        responses={status.HTTP_200_OK: serializer_class},
+    )
+    def patch(self, request, *args, **kwargs):
+        kwargs["partial"] = True
+        return super().update(request, *args, **kwargs)

django/thunderstore/api/urls.py

@@ -23,6 +23,7 @@
     TeamMemberListAPIView,
     TeamServiceAccountListAPIView,
     UpdatePackageListingCategoriesAPIView,
+    UpdateTeamAPIView,
 )
 
 cyberstorm_urls = [
@@ -126,6 +127,11 @@
         TeamAPIView.as_view(),
         name="cyberstorm.team",
     ),
+    path(
+        "team/<str:team_name>/update/",
+        UpdateTeamAPIView.as_view(),
+        name="cyberstorm.team.update",
+    ),
     path(
         "team/<str:team_name>/disband/",
         DisbandTeamAPIView.as_view(),