Skip to content

Add windows workflow #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: ros2-master
Choose a base branch
from
Draft

Add windows workflow #238

wants to merge 8 commits into from

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Nov 24, 2024

Needs ros-controls/ros2_control_ci#374

I had to make a workaround for RSL, because colcon+MSVC does not consider the CMakePresets file.

Needs upstream changes:

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.72%. Comparing base (0336ef4) to head (04e2c70).

Additional details and impacted files
@@             Coverage Diff              @@
##           ros2-master     #238   +/-   ##
============================================
  Coverage        76.72%   76.72%           
============================================
  Files               30       30           
  Lines             1744     1744           
  Branches           107      107           
============================================
  Hits              1338     1338           
  Misses             346      346           
  Partials            60       60           
Flag Coverage Δ
unittests 76.72% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
control_toolbox/src/pid.cpp 68.38% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Mar 31, 2025
Copy link

mergify bot commented Mar 31, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@github-actions github-actions bot removed the stale label Apr 1, 2025
Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label May 16, 2025
@github-actions github-actions bot removed the stale label Jun 16, 2025
# (github.event_name == 'issue_comment' && contains(github.event.comment.body, '/check-windows')) ||
# (github.event_name == 'pull_request' && contains(github.event.label.name, 'check-windows')) ||
# (github.event_name == 'workflow_dispatch')
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-ros-tooling-win-build.yml@windows/pixi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-ros-tooling-win-build.yml@windows/pixi
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-ros-tooling-win-build.yml@master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants