Make filters compile with MSVC #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sys/time.h is not available on windows
CMake Error at CMakeLists.txt:229 (add_custom_command):
Exactly one of PRE_BUILD, PRE_LINK, or POST_BUILD must be given.
1 task
|
Thanks a lot for working on this, this is really useful! |
|
Thanks for this! I'll try to get around to reviewing it today. |
jonbinney
reviewed
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time, ros2_control framework gets user feedback (@traversaro for example ;)) for build errors on Windows. I worked on a github CI job to build our stack on rolling with pixi, but the filters package needs some changes to make it compile.
I don't use ROS on Windows apart from the CI job, maybe there are other ways to achieve this?