Skip to content

Add windows workflow #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: ros2-master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/rolling-semi-binary-build-win.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: Rolling Windows Semi-Binary Build
# author: Christoph Fröhlich <[email protected]>
# description: 'Build & test all dependencies from semi-binary packages.'

on:
workflow_dispatch:
pull_request:
branches:
- ros2-master
# types:
# - labeled
push:
branches:
- ros2-master
# issue_comment:
# types:
# - created

jobs:
binary-windows:
# if: |
# (github.event_name == 'issue_comment' && contains(github.event.comment.body, '/check-windows')) ||
# (github.event_name == 'pull_request' && contains(github.event.label.name, 'check-windows')) ||
# (github.event_name == 'workflow_dispatch')
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-ros-tooling-win-build.yml@windows/pixi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-ros-tooling-win-build.yml@windows/pixi
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-ros-tooling-win-build.yml@master

with:
ros_distro: rolling
ref_for_scheduled_build: master
pixi_dependencies: typeguard jinja2 boost compilers
windows_dependencies: control_toolbox.windows.rolling.repos
ninja_packages: rsl
17 changes: 17 additions & 0 deletions control_toolbox.windows.rolling.repos
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
repositories:
filters:
type: git
url: https://github.com/christophfroehlich/filters.git
version: ros2-boost
cpp_polyfills:
type: git
url: https://github.com/PickNikRobotics/cpp_polyfills.git
version: main
rsl:
type: git
url: https://github.com/PickNikRobotics/RSL.git
version: main
generate_parameter_library:
type: git
url: https://github.com/PickNikRobotics/generate_parameter_library.git
version: main
2 changes: 1 addition & 1 deletion control_toolbox/src/pid.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ double Pid::compute_command(double error, double error_dot, const double & dt_s)
}
else if (gains.antiwindup_strat_ == AntiwindupStrategy::CONDITIONAL_INTEGRATION)
{
if (!(!iszero(cmd_unsat_ - cmd_) && error * cmd_unsat_ > 0))
if (!(!is_zero(cmd_unsat_ - cmd_) && error * cmd_unsat_ > 0))
{
i_term_ += dt_s * gains.i_gain_ * error;
}
Expand Down
Loading