Playback speed not being used fix

[Lasercar]

Does this PR close any issues? If so, link them below.

Fixes #4176

Briefly describe the issue(s) fixed.

The change to the conductor to fix the resync didn't account for if the music's pitch was different. This PR fixes that.

Maybe the check isn't needed and the music time can be used instead? IDK.

Include any relevant screenshots or videos.

2025-02-19.20-56-22.1.mp4

Bonus: Ugh at 2 times playback speed

2025-02-19.21-05-39.1.mp4

[JackXson-Real]

This fixes the issue of the song being in swing mode, but unfortunately its still broken.

Base.Profile.2025.02.19.-.20.12.19.02.mp4

[Hundrec]

Works well for me!

[JackXson-Real]

Im going to do some addition testing to see if I can figure out the cause of this issue for me. It seems to work fine for @Hundrec

[JackXson-Real]

This fixes the issue of the song being in swing mode, but unfortunately its still broken.

Base.Profile.2025.02.19.-.20.12.19.02.mp4

Ok I found what causes the issue. Having visual offsets set to anything other than 0 causes this skipping to happen. I bet if PR #3732 and this were in the same build, I wouldnt have the issue.

Edit: Just tested the above mentioned PR and it seems to fix my issue. Once both of these issues are merged together, there should be no issues. I will approve this PR.

[Lasercar]

This fixes the issue of the song being in swing mode, but unfortunately its still broken.
Base.Profile.2025.02.19.-.20.12.19.02.mp4

Ok I found what causes the issue. Having visual offsets set to anything other than 0 causes this skipping to happen. I bet if PR #3732 and this were in the same build, I wouldnt have the issue.

Edit: Just tested the above mentioned PR and it seems to fix my issue. Once both of these issues are merged together, there should be no issues. I will approve this PR.

Yeah, the issue you encountered was just fixed by this #4171

It was a funny issue (an abnormal one, even), and I was still in the middle of trying to fix the bug so I just forgot to update my fork. By the time I noticed when I was getting a video for it, I just thought it'd be funnier if I just left it as so. It's not like it currently conflicts with anything, right?

[Lasercar]

Hundrec's busy testing this Conductor.instance.update(FlxG.sound.music.time + elapsed * 1000, false);

It seems to fix both the song not ending issue that the change introduced, this one and the stuttering issues, though it needs more testing.

If it can be fully confirmed to fix all three, I'll change this PR appropriately.

Edit: It does, but it breaks GF's neck, so maybe not.

[Lasercar]

Superseded by #4334

(if you don't mind or can fix the weird issue hundrec found)

[Hundrec]

Merge conflicts: 6

[Lasercar]

Merge conflicts: Fixed!

[TechnikTil]

Sorry for causing this-ish😅

[Hundrec]

So it turns out GF or Nene has a seizure with this change...

chud.mp4

[Lasercar]

So it turns out GF or Nene has a seizure with this change...
chud.mp4

yeah uh, I tried investigating how to fix this for the conductor-fixed but I couldn't figure it out. I was able to discover that whatever calls the onStepHit for boppers seems to starts doing it multiple times when you do the pause/unpause mash, though.

Feel free to add help-wanted to this and/or conductor-fixed

[Lasercar]

#5107

[github-actions]

This pull request is a duplicate. Please direct all discussion to the original pull request.