Skip to content

Bug Report: Playback speed does some weird (cool) stuff in playtest mode #4176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
JackXson-Real opened this issue Feb 18, 2025 · 20 comments
Open
3 tasks done
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.

Comments

@JackXson-Real
Copy link
Contributor

JackXson-Real commented Feb 18, 2025

Issue Checklist

  • I have read the Contributing Guide
  • I have checked the Issues/Discussions pages to see if my issue has already been reported
  • I have properly titled my issue

Platform

Compiled from GitHub Source Code

Browser

None

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

Edit: This only seems to happen on the develop branch of the game.

Setting playback speed in chart editor to something lower lowers the pitch, but doesn't slow the game down causing this cool audio bug. The playback audio should also affect game speed in playtesting mode.

Cool video to demonstrate:
https://www.youtube.com/watch?v=bfSbLA3VGFM

Steps to Reproduce

  1. Open chart in chart editor
  2. Lower playback speed in audio tab
  3. Go into playtest mode (works on both normal and minimal playtest)
@JackXson-Real JackXson-Real added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. labels Feb 18, 2025
@JackXson-Real
Copy link
Contributor Author

Who else agrees that this goes very hard

@Trofem
Copy link

Trofem commented Feb 18, 2025

I think changing voices pitch (+song speed as global) would be cool if can be implemented as additional settings for .fnfc files.

@JVNpixels
Copy link
Contributor

This is weird, I am pretty sure they fixed this issue already? Unless if another one popped out of no-where while they were updating the game. This looks cool! It should be fixed though.

@JackXson-Real
Copy link
Contributor Author

This is weird, I am pretty sure they fixed this issue already? Unless if another one popped out of no-where while they were updating the game. This looks cool! It should be fixed though.

It probably got reintroduced due to some change added to the develop branch. This bug doesn't happen on the stable build of 0.5.3, but it happens on the compiled develop branch.

@JVNpixels
Copy link
Contributor

I am assuming that is what happened, but regardless I like the pirate bug!

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 19, 2025

Swing Mode 2

@JackXson-Real
Copy link
Contributor Author

Swing Mode 2

It’s a sign that this needs to be implemented officially 🤣

@Lasercar
Copy link
Contributor

Ugh, why does that sound so cool?

@Lasercar
Copy link
Contributor

Lasercar commented Feb 19, 2025

Hmm, whatever the issue is it isn't with the playstate itself, the code's exactly the same. It's something else.

I noticed that the countdown seems to start the slow down? Nope, it's also exactly the same. The conductor is the same too.

I found the issue, it's the change to this line here:

Conductor.instance.update(Conductor.instance.songPosition + elapsed * 1000, false); // Normal conductor update.

Change made by this merged PR:
#3955

I'm going to try and figure out a fix that doesn't involve removing the resync stuff. Done!

Now I just have to make a branch, PR and record a video of it. Done!

#4182

@Lasercar
Copy link
Contributor

This issue now has a pending PR.

@amyspark-ng
Copy link
Contributor

i found this issue a bit ago while playing on the develop branch and forgot to report it! thank you

@AbnormalPoof AbnormalPoof added status: pending pull request Dependent on a pull request that is currently awaiting review. topic: chart editor Related to the operation of the Chart Editor. and removed status: pending triage Awaiting review. labels Feb 22, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Mar 17, 2025

Playable! 👍

huh.mp4

@AbnormalPoof
Copy link
Collaborator

what.is.this.mp4

@charlesisfeline
Copy link

close enough, welcome back swing mode bug

@JackXson-Real
Copy link
Contributor Author

Still present in 0.6.1.

@Yasfunny
Copy link

Yasfunny commented Apr 6, 2025

That bug came back in the Pitstop 2 lmao

@Lasercar
Copy link
Contributor

Lasercar commented Apr 6, 2025

That bug came back in the Pitstop 2 lmao

It was always a bug since [the] 0.5.3 [develop branch].

@Yasfunny
Copy link

Yasfunny commented Apr 6, 2025

That bug came back in the Pitstop 2 lmao

It was always a bug since 0.5.3.

i personally didn't have it in Playable Pico builds, strange

@Lasercar
Copy link
Contributor

Lasercar commented Apr 6, 2025

Yeah, it was a develop branch only bug, that wasn't fixed for 0.6.0.

@Hundrec
Copy link
Collaborator

Hundrec commented May 10, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants