Bug Report: Playback speed does some weird (cool) stuff in playtest mode

[JackXson-Real]

Issue Checklist

• I have read the Contributing Guide
• I have checked the Issues/Discussions pages to see if my issue has already been reported
• I have properly titled my issue

Platform

Compiled from GitHub Source Code

Browser

None

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

Edit: This only seems to happen on the develop branch of the game.

Setting playback speed in chart editor to something lower lowers the pitch, but doesn't slow the game down causing this cool audio bug. The playback audio should also affect game speed in playtesting mode.

Cool video to demonstrate:
https://www.youtube.com/watch?v=bfSbLA3VGFM

Steps to Reproduce

1. Open chart in chart editor
2. Lower playback speed in audio tab
3. Go into playtest mode (works on both normal and minimal playtest)

[JackXson-Real]

Who else agrees that this goes very hard

[Trofem]

I think changing voices pitch (+song speed as global) would be cool if can be implemented as additional settings for .fnfc files.

[JVNpixels]

This is weird, I am pretty sure they fixed this issue already? Unless if another one popped out of no-where while they were updating the game. This looks cool! It should be fixed though.

[JackXson-Real]

This is weird, I am pretty sure they fixed this issue already? Unless if another one popped out of no-where while they were updating the game. This looks cool! It should be fixed though.

It probably got reintroduced due to some change added to the develop branch. This bug doesn't happen on the stable build of 0.5.3, but it happens on the compiled develop branch.

[JVNpixels]

I am assuming that is what happened, but regardless I like the pirate bug!

[Hundrec]

Swing Mode 2

[JackXson-Real]

Swing Mode 2

It’s a sign that this needs to be implemented officially 🤣

[Lasercar]

Ugh, why does that sound so cool?

[Lasercar]

Hmm, whatever the issue is it isn't with the playstate itself, the code's exactly the same. It's something else.

I noticed that the countdown seems to start the slow down? Nope, it's also exactly the same. The conductor is the same too.

I found the issue, it's the change to this line here:

Funkin/source/funkin/play/PlayState.hx

Line 919 in 5054c58

Conductor.instance.update(Conductor.instance.songPosition + elapsed * 1000, false); // Normal conductor update.

Change made by this merged PR:
#3955

I'm going to try and figure out a fix that doesn't involve removing the resync stuff. Done!

Now I just have to make a branch, PR and record a video of it. Done!

#4182

[Lasercar]

This issue now has a pending PR.

[amyspark-ng]

i found this issue a bit ago while playing on the develop branch and forgot to report it! thank you

[Hundrec]

Playable! 👍

huh.mp4

[AbnormalPoof]

what.is.this.mp4

[charlesisfeline]

close enough, welcome back swing mode bug

[JackXson-Real]

Still present in 0.6.1.

[Yasfunny]

That bug came back in the Pitstop 2 lmao

[Lasercar]

That bug came back in the Pitstop 2 lmao

It was always a bug since [the] 0.5.3 [develop branch].

[Yasfunny]

That bug came back in the Pitstop 2 lmao

It was always a bug since 0.5.3.

i personally didn't have it in Playable Pico builds, strange

[Lasercar]

Yeah, it was a develop branch only bug, that wasn't fixed for 0.6.0.

[Hundrec]

Turns out this was caused by the same change as #5049
https://github.com/FunkinCrew/Funkin/pull/3955/files#diff-d735da8a36bf5a753af53c828f8a2213a4cd5bf5bad648e262c3391f9fb8f442R909