Skip to content

[BUGFIXES] Chart editor - Set playspeed after variation load, volumes being reset to 100% #4212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[BUGFIXES] Chart editor - Set playspeed after variation load, volumes being reset to 100% #4212

wants to merge 2 commits into from

Conversation

Lasercar
Copy link
Contributor

@Lasercar Lasercar commented Feb 23, 2025 •
edited
Loading

Does this PR close any issues? If so, link them below.

Fixes #3041, fixes #3463

Briefly describe the issue(s) fixed.

When a variation is loaded (or an audiotrack is reloaded), the new audiotracks don't have their playback speed set.

This PR fixes that, by doing after they're loaded.

Volume resets to 100% after playtest.

The volume sliders use values of 100 and isn't divided down to a single float, so it'd always be set to 100% after a playtest or a different audio track being loaded.

Include any relevant screenshots or videos.

@Lasercar Lasercar changed the base branch from main to develop February 23, 2025 03:58
@github-actions github-actions bot added size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. status: pending triage Awaiting review. and removed size: small A small pull request with 10 or fewer changes. labels Feb 23, 2025
@AbnormalPoof AbnormalPoof added type: minor bug Involves a minor bug or issue. topic: chart editor Related to the operation of the Chart Editor. size: small A small pull request with 10 or fewer changes. labels Feb 23, 2025
Hundrec
Hundrec suggested changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work in my testing, not sure why!

@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Feb 27, 2025
@Lasercar Lasercar force-pushed the chart-editor-set-play-speed-after-variation-load branch from ae43086 to 8e8e7f1 Compare February 28, 2025 11:51
@Lasercar
Copy link
Contributor Author

This doesn't work in my testing, not sure why!

Whoops, that's because I was dumb and didn't notice that I put the pitch changes in the audioInstTrack.onComplete function.

@Lasercar Lasercar requested a review from Hundrec March 1, 2025 00:41
Hundrec
Hundrec suggested changes Mar 1, 2025
View reviewed changes
Copy link
Collaborator

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's because #4182 hasn't been merged, but switching variations now causes the speed to stay but the pitch to revert to normal.
There's also a strange distortion effect until you change the playback speed again.

@Lasercar
Copy link
Contributor Author

Lasercar commented Mar 1, 2025

Not sure if it's because #4182 hasn't been merged, but switching variations now causes the speed to stay but the pitch to revert to normal. There's also a strange distortion effect until you change the playback speed again.

Huh? How??? That shouldn't be possible, the speed and pitch are the same thing. Do you think you could get a video of this? I didn't encounter this issue in my test of it.

@Hundrec
Copy link
Collaborator

Hundrec commented Mar 14, 2025

This video hurts my soul

awful.video.mp4

@Lasercar Lasercar force-pushed the chart-editor-set-play-speed-after-variation-load branch from 8e8e7f1 to c539063 Compare March 14, 2025 07:43
@github-actions github-actions bot added size: medium A medium pull request with 100 or fewer changes. and removed size: small A small pull request with 10 or fewer changes. labels Mar 14, 2025
@Lasercar Lasercar requested a review from Hundrec March 14, 2025 10:25
@Lasercar
Copy link
Contributor Author

This video hurts my soul
awful.video.mp4

You should now no longer experience any soul hurting with this PR.

@Hundrec Hundrec added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Mar 15, 2025
Hundrec
Hundrec approved these changes Mar 22, 2025
View reviewed changes
Copy link
Collaborator

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more soul hurting

@EliteMasterEric EliteMasterEric added size: medium A medium pull request with 100 or fewer changes. and removed size: medium A medium pull request with 100 or fewer changes. labels May 14, 2025
@Lasercar Lasercar mentioned this pull request May 16, 2025
Open
2 tasks
@Lasercar Lasercar force-pushed the chart-editor-set-play-speed-after-variation-load branch from c539063 to b0e14c8 Compare May 16, 2025 12:11
@Lasercar Lasercar changed the title Chart editor - Set playspeed after variation load [BUGFIXES] Chart editor - Set playspeed after variation load, volumes being reset to 100% May 16, 2025
@Lasercar Lasercar force-pushed the chart-editor-set-play-speed-after-variation-load branch from b0e14c8 to 0ebe32e Compare May 16, 2025 12:13
@Lasercar Lasercar changed the base branch from develop to main May 16, 2025 12:18
@Lasercar Lasercar changed the base branch from main to develop May 16, 2025 12:18
@Lasercar Lasercar requested a review from Hundrec May 16, 2025 12:18
Hundrec
Hundrec approved these changes May 16, 2025
View reviewed changes
Copy link
Collaborator

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this fixes #3463!

@Lasercar Lasercar force-pushed the chart-editor-set-play-speed-after-variation-load branch from 0ebe32e to 4862b19 Compare May 16, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hundrec Hundrec Hundrec approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
No milestone
4 participants
@Lasercar @Hundrec @EliteMasterEric @AbnormalPoof