-
Notifications
You must be signed in to change notification settings - Fork 106
Redefine the antiwindup strategy and their parameters interfacing #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redefine the antiwindup strategy and their parameters interfacing #400
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ros2-master #400 +/- ##
===============================================
+ Coverage 76.72% 78.41% +1.69%
===============================================
Files 30 30
Lines 1744 1886 +142
Branches 107 113 +6
===============================================
+ Hits 1338 1479 +141
+ Misses 346 338 -8
- Partials 60 69 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice work!
Co-authored-by: Felix Exner (fexner) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Some tests are failing, though. |
I'll check |
(cherry picked from commit 910093d) # Conflicts: # control_toolbox/include/control_toolbox/pid.hpp # control_toolbox/include/control_toolbox/pid_ros.hpp # control_toolbox/src/pid.cpp
…ckport #400) (#410) Co-authored-by: Sai Kishor Kothakota <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]>
Second PR for the antiwindup strategy integration