-
-
Notifications
You must be signed in to change notification settings - Fork 39
Cleanup indicies #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Cleanup indicies #526
Conversation
Should this be marked as draft so it doesn't get merged unintentionally? |
Merging blocked until we're ready to update the boorus, aka until Debian Trixie is released (june-august time window). |
Could you elaborate on why this change is blocked by updating the underlying OS? |
It's not blocked by the update itself, but by the logistics required to deploy it. Basically to deploy this and the other indexing change, I'd have to delete all search indices and reindex anew, something that has to be done while the site is offline and will take 45-60 minutes. Since a debian distro version upgrade requires a host reboot and some downtime too, why not just combine the two into one big downtime. |
I see, that makes sense. @mdashlw do you think reindexing is actually required after this PR is merged? I haven't looked into it closely yet, so I'm just asking. What if we merge this PR and don't do a reindex, does it mean the boorus become more broken than they are today, or not? If not, then merging should be harmless |
It would require a reindex lest things will be hilariously broken. |
To be specific, the changes are incompatible (namespaced_tags structure vs tags). |
Before you begin
Requires a total reindex. WIP PR until we decide to do that
updated_at
to commentsthumbnail_id
andspoiler_warning
to gallerieswatcher_ids
from galleriesscratchpad
to imagesdeleted_by_user_id
,deleted_by_user
, anddeletion_reason
to posts & commentsauthor
to anon posts & commentsnamespaced_tags
on imagesdestroyed_content
to posts & commentsCloses #517 and #519