-
-
Notifications
You must be signed in to change notification settings - Fork 39
Fix types of _id fields #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
62e4fe6
to
5e04519
Compare
5e04519
to
95f9f41
Compare
As this change has something to do with indices, this is blocked similarly to #526 (see comments on that PR) |
This only touches query parsers not indices. Should be fine to merge |
@@ -3,10 +3,10 @@ defmodule Philomena.Reports.Query do | |||
|
|||
defp fields do | |||
[ | |||
int_fields: ~W(id image_id), | |||
int_fields: ~W(id), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdashlw why not turn id
into a numeric_field
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it needs to support range querying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it doesn't make sense to support range queries for relational IDs like image_id
? IIRC it should cost nothing, right?
QAComments
GalleriesImages
Posts
Reports
|
Before you begin
I'm not sure why int and float parsers explicitly ignore spaces, didn't put that into the new parser