fix: Enable node-param-default-wrong-for-string lint rule and autofix #20301
+438
−423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
14 issues found across 191 files
Note: This PR contains a large number of files. cubic only reviews up to 150 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all 14 issues)
Understand the root cause of the following 14 issues and fix them.
<file name="packages/nodes-base/nodes/Freshdesk/ContactDescription.ts">
<violation number="1" location="packages/nodes-base/nodes/Freshdesk/ContactDescription.ts:371">
Defaulting the Freshdesk contact state to 'blocked' means anyone adding this optional field will create/update contacts as blocked unless they remember to change it. Please default it to the normal active state instead to avoid locking out contacts.</violation>
</file>
<file name="packages/nodes-base/nodes/Bitwarden/descriptions/MemberDescription.ts">
<violation number="1" location="packages/nodes-base/nodes/Bitwarden/descriptions/MemberDescription.ts:214">
Setting the update “Type” field default to 0 now auto-selects “Owner”, so adding this optional field silently escalates members to owner unless the user changes it. Please default to the safe, non-privileged value instead (e.g. match the create default of 2).</violation>
</file>
<file name="packages/nodes-base/nodes/Box/FolderDescription.ts">
<violation number="1" location="packages/nodes-base/nodes/Box/FolderDescription.ts:291">
Setting the direction field’s default to 'ASC' contradicts both the description (“Default value is DESC”) and Box’s API default, so users who add this field without changing the value will get ascending ordering instead of the documented default. Please default to 'DESC'.</violation>
</file>
<file name="packages/nodes-base/nodes/Phantombuster/AgentDescription.ts">
<violation number="1" location="packages/nodes-base/nodes/Phantombuster/AgentDescription.ts:212">
Changing the default prevStatus to `'finished'` forces every added field to filter for finished runs instead of leaving the status unset; please keep the default blank and satisfy the lint rule by introducing an explicit "Not set" option instead.</violation>
</file>
<file name="packages/nodes-base/nodes/Intercom/LeadDescription.ts">
<violation number="1" location="packages/nodes-base/nodes/Intercom/LeadDescription.ts:76">
Switching the default from an unset value to `'id'` changes existing workflows: previously missing `deleteBy` values followed the userId code path, but now they call `/contacts/{value}`. Workflows that stored a `user_id` will suddenly fail to delete the target lead. Please keep the default aligned with the previous behavior by defaulting to `'userId'`.</violation>
</file>
<file name="packages/nodes-base/nodes/Shopify/OrderDescription.ts">
<violation number="1" location="packages/nodes-base/nodes/Shopify/OrderDescription.ts:236">
Setting this dropdown’s default to 'fulfilled' means that merely adding the Fulfillment Status field now submits orders as fulfilled unless the user manually changes it. Shopify orders should default to the unfulfilled ('null') state, so please keep the default at that value.</violation>
</file>
<file name="packages/nodes-base/nodes/MessageBird/MessageBird.node.ts">
<violation number="1" location="packages/nodes-base/nodes/MessageBird/MessageBird.node.ts:257">
Changing the Type option default to 'binary' means that simply adding this optional field now posts type='binary', forcing MessageBird to expect binary payloads instead of the normal SMS default. Please default to 'sms' so behaviour matches the API default and the pre-PR behaviour.</violation>
</file>
<file name="packages/nodes-base/nodes/Hubspot/V2/EngagementDescription.ts">
<violation number="1" location="packages/nodes-base/nodes/Hubspot/V2/EngagementDescription.ts:157">
Setting the task status default to "COMPLETED" means any task created without manually changing this field is immediately marked done; default to "NOT_STARTED" (HubSpot's initial state) instead so tasks start open.</violation>
</file>
<file name="packages/nodes-base/nodes/Hubspot/V2/ContactDescription.ts">
<violation number="1" location="packages/nodes-base/nodes/Hubspot/V2/ContactDescription.ts:282">
These optional HubSpot contact properties used to default to an empty string so the field stayed unset until the user explicitly picked a value. Changing the default to a real enum (e.g. 'SUSPENSION_REMEDIATION') now preselects data, so simply adding the field without touching the dropdown will send incorrect information. Please keep the default at '' and add an explicit "Not set" option (value '') to satisfy the lint rule instead of auto-selecting a real value. Apply the same fix to employmentRole, employmentSeniority, employmentSubRole, inferredLanguageCodes, latestTrafficSource, and timeZone.</violation>
</file>
<file name="packages/nodes-base/nodes/BambooHr/v1/actions/employee/create/shareDescription.ts">
<violation number="1" location="packages/nodes-base/nodes/BambooHr/v1/actions/employee/create/shareDescription.ts:105">
Setting this default to 'exempt' makes create() always send FLSA status even when the user leaves the field unset, because execute.ts unconditionally assigns the parameter. The empty-string default kept the field optional. The same regression hits the other option defaults changed in this file, so please keep them blank.</violation>
</file>
<file name="packages/nodes-base/nodes/Merge/v2/descriptions.ts">
<violation number="1" location="packages/nodes-base/nodes/Merge/v2/descriptions.ts:19">
Resetting this parameter now chooses the add-suffix behavior even though the node default remains preferInput2, so "reset to default" renames fields instead of preserving the intended preference. Please align the default with the existing node default.</violation>
</file>
<file name="packages/nodes-base/nodes/Mailchimp/Mailchimp.node.ts">
<violation number="1" location="packages/nodes-base/nodes/Mailchimp/Mailchimp.node.ts:344">
Setting the required member status default to 'cleaned' now auto-submits new members as cleaned (bounced) accounts; keep the empty default so users must choose an appropriate status.</violation>
</file>
<file name="packages/nodes-base/nodes/HelpScout/CustomerDescription.ts">
<violation number="1" location="packages/nodes-base/nodes/HelpScout/CustomerDescription.ts:118">
Setting the update Gender field’s default to `female` forces an unintended overwrite when the user merely adds the field. Use the neutral `unknown` option instead so adding Gender doesn’t silently flip customers to female.</violation>
</file>
<file name="packages/nodes-base/nodes/Onfleet/descriptions/ContainerDescription.ts">
<violation number="1" location="packages/nodes-base/nodes/Onfleet/descriptions/ContainerDescription.ts:56">
The new default container type is set to 'organizations', but addTask/updateTask still assume 'workers' as the fallback. This mismatch causes the node to hit the wrong containers endpoint by default.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
packages/nodes-base/nodes/Bitwarden/descriptions/MemberDescription.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/BambooHr/v1/actions/employee/create/shareDescription.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Onfleet/descriptions/ContainerDescription.ts
Outdated
Show resolved
Hide resolved
n8n-assistant
bot
added
n8n team
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
n8n-nodes-base/node-param-default-wrong-for-stringlint ruleBlocked by: ivov/eslint-plugin-n8n-nodes-base#201
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-3037/add-lint-rule-to-ensure-the-default-option-value-is-one-of-the
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)