Skip to content

Fix node-param-default-wrong-for-options autofix #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2025
Merged

Fix node-param-default-wrong-for-options autofix #201

merged 1 commit into from
Oct 6, 2025

Conversation

elsmr
Copy link
Contributor

@elsmr elsmr commented Oct 2, 2025 •
edited
Loading

The lint fix for the node-param-default-wrong-for-options rule would not work correctly in a few cases:

  • When there is a loadOptionsMethod or loadOptions object, it would clear it ('')
    • New behavior: allow any value
  • When default was set to a variable (or any non-literal expression), it would replace it
    • New behavior: allow any expression that is not a literal

Related PR: n8n-io/n8n#20301

@elsmr elsmr mentioned this pull request Oct 2, 2025
Draft
4 tasks
ivov
ivov approved these changes Oct 6, 2025
View reviewed changes
Copy link
Owner

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@ivov ivov merged commit 2c7cd19 into ivov:master Oct 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivov ivov ivov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elsmr @ivov