Skip to content

fix: Enable node-param-default-wrong-for-string lint rule and autofix #20301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
+442 −416
Draft

fix: Enable node-param-default-wrong-for-string lint rule and autofix #20301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
728abb1
Enable node-param-default-wrong-for-string rule and autofix
elsmr Oct 2, 2025
2269404
Manual default adjustments after review
elsmr Oct 2, 2025
9b7d1ae
1 more default adjustment
elsmr Oct 2, 2025
1ff924c
Update eslint-plugin-n8n-nodes-base
elsmr Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@n8n/nodes-langchain/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ export default defineConfig(
'n8n-nodes-base/node-param-default-wrong-for-fixed-collection': 'error',
'n8n-nodes-base/node-param-default-wrong-for-fixed-collection': 'error',
'n8n-nodes-base/node-param-default-wrong-for-multi-options': 'error',
'n8n-nodes-base/node-param-default-wrong-for-options': 'error',
'n8n-nodes-base/node-param-default-wrong-for-number': 'error',
'n8n-nodes-base/node-param-default-wrong-for-simplify': 'error',
'n8n-nodes-base/node-param-default-wrong-for-string': 'error',
Expand Down
2 changes: 1 addition & 1 deletion packages/@n8n/nodes-langchain/nodes/agents/Agent/V1/AgentV1.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ const agentTypeProperty: INodeProperties = {
'Specializes in interacting with SQL databases. Ideal for data analysis tasks, generating queries, or extracting insights from structured data.',
},
],
default: '',
default: 'toolsAgent',
};

export class AgentV1 implements INodeType {
Expand Down
1 change: 1 addition & 0 deletions packages/@n8n/nodes-langchain/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@
"@types/pg": "^8.11.6",
"@types/sanitize-html": "^2.11.0",
"@types/temp": "^0.9.1",
"eslint-plugin-n8n-nodes-base": "catalog:",
"fast-glob": "catalog:",
"jest-mock-extended": "^3.0.4",
"n8n-core": "workspace:*",
Expand Down
1 change: 1 addition & 0 deletions packages/nodes-base/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ export default defineConfig(
'n8n-nodes-base/node-param-default-wrong-for-fixed-collection': 'error',
'n8n-nodes-base/node-param-default-wrong-for-fixed-collection': 'error',
'n8n-nodes-base/node-param-default-wrong-for-multi-options': 'error',
'n8n-nodes-base/node-param-default-wrong-for-options': 'error',
'n8n-nodes-base/node-param-default-wrong-for-number': 'error',
'n8n-nodes-base/node-param-default-wrong-for-simplify': 'error',
'n8n-nodes-base/node-param-default-wrong-for-string': 'error',
Expand Down
4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/ActiveCampaign/ContactDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ export const contactFields: INodeProperties[] = [
value: 2,
},
],
default: '',
default: 1,
},
{
displayName: 'Tag ID',
Expand Down Expand Up @@ -480,7 +480,7 @@ export const contactFields: INodeProperties[] = [
description: 'Order contacts by score',
},
],
default: '',
default: 'orders[cdate]',
},
],
},
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/AcuityScheduling/AcuitySchedulingTrigger.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export class AcuitySchedulingTrigger implements INodeType {
name: 'event',
type: 'options',
required: true,
default: '',
default: 'appointment.canceled',
options: [
{
name: 'appointment.canceled',
Expand Down
12 changes: 6 additions & 6 deletions packages/nodes-base/nodes/AgileCrm/CompanyDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ export const companyFields: INodeProperties[] = [
name: 'subtype',
type: 'options',
required: true,
default: '',
default: 'postal',
description: 'Type of address',
options: [
{
Expand Down Expand Up @@ -447,7 +447,7 @@ export const companyFields: INodeProperties[] = [
displayName: 'Star Value',
name: 'starValue',
type: 'options',
default: '',
default: 0,
description: 'Rating of company (Max value 5). This is not applicable for companies.',
options: [
{
Expand Down Expand Up @@ -507,7 +507,7 @@ export const companyFields: INodeProperties[] = [
name: 'subtype',
type: 'options',
required: true,
default: '',
default: 'facebook',
description: 'Type of website',
options: [
{
Expand Down Expand Up @@ -708,7 +708,7 @@ export const companyFields: INodeProperties[] = [
name: 'subtype',
type: 'options',
required: true,
default: '',
default: 'postal',
description: 'Type of address',
options: [
{
Expand Down Expand Up @@ -745,7 +745,7 @@ export const companyFields: INodeProperties[] = [
displayName: 'Star Value',
name: 'starValue',
type: 'options',
default: '',
default: 0,
description: 'Rating of company (Max value 5). This is not applicable for companies.',
options: [
{
Expand Down Expand Up @@ -819,7 +819,7 @@ export const companyFields: INodeProperties[] = [
name: 'subtype',
type: 'options',
required: true,
default: '',
default: 'facebook',
description: 'Type of website',
options: [
{
Expand Down
20 changes: 10 additions & 10 deletions packages/nodes-base/nodes/AgileCrm/ContactDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ export const contactFields: INodeProperties[] = [
name: 'subtype',
type: 'options',
required: true,
default: '',
default: 'home',
description: 'Type of address',
options: [
{
Expand Down Expand Up @@ -454,7 +454,7 @@ export const contactFields: INodeProperties[] = [
name: 'subtype',
type: 'options',
required: true,
default: '',
default: 'work',
description: 'Type of Email',
options: [
{
Expand Down Expand Up @@ -507,7 +507,7 @@ export const contactFields: INodeProperties[] = [
displayName: 'Star Value',
name: 'starValue',
type: 'options',
default: '',
default: 0,
description: 'Rating of contact (Max value 5). This is not applicable for companies.',
options: [
{
Expand Down Expand Up @@ -555,7 +555,7 @@ export const contactFields: INodeProperties[] = [
name: 'subtype',
type: 'options',
required: true,
default: '',
default: 'home',
description: 'Type of phone number',
options: [
{
Expand Down Expand Up @@ -638,7 +638,7 @@ export const contactFields: INodeProperties[] = [
name: 'subtype',
type: 'options',
required: true,
default: '',
default: 'facebook',
description: 'Type of website',
options: [
{
Expand Down Expand Up @@ -839,7 +839,7 @@ export const contactFields: INodeProperties[] = [
name: 'subtype',
type: 'options',
required: true,
default: '',
default: 'home',
description: 'Type of address',
options: [
{
Expand Down Expand Up @@ -894,7 +894,7 @@ export const contactFields: INodeProperties[] = [
name: 'subtype',
type: 'options',
required: true,
default: '',
default: 'work',
description: 'Type of Email',
options: [
{
Expand Down Expand Up @@ -947,7 +947,7 @@ export const contactFields: INodeProperties[] = [
displayName: 'Star Value',
name: 'starValue',
type: 'options',
default: '',
default: 0,
description: 'Rating of contact (Max value 5). This is not applicable for companies.',
options: [
{
Expand Down Expand Up @@ -995,7 +995,7 @@ export const contactFields: INodeProperties[] = [
name: 'subtype',
type: 'options',
required: true,
default: '',
default: 'home',
description: 'Type of phone number',
options: [
{
Expand Down Expand Up @@ -1078,7 +1078,7 @@ export const contactFields: INodeProperties[] = [
name: 'subtype',
type: 'options',
required: true,
default: '',
default: 'facebook',
description: 'Type of website',
options: [
{
Expand Down
4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/Automizy/ContactDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export const contactFields: INodeProperties[] = [
value: 'UNSUBSCRIBED',
},
],
default: '',
default: 'ACTIVE',
description:
'The status of the contact. You can only send email to contacts with ACTIVE status.',
},
Expand Down Expand Up @@ -431,7 +431,7 @@ export const contactFields: INodeProperties[] = [
value: 'UNSUBSCRIBED',
},
],
default: '',
default: 'ACTIVE',
description:
'The status of the contact. You can only send email to contacts with ACTIVE status.',
},
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Autopilot/AutopilotTrigger.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class AutopilotTrigger implements INodeType {
name: 'event',
type: 'options',
required: true,
default: '',
default: 'contactAdded',
options: [
{
name: 'Contact Added',
Expand Down
4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/Aws/S3/V1/BucketDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export const bucketFields: INodeProperties[] = [
value: 'publicReadWrite',
},
],
default: '',
default: 'authenticatedRead',
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Oct 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaulting the ACL to “authenticatedRead” means adding the optional ACL field without changing it will send x-amz-acl: authenticated-read, exposing the bucket’s contents to every AWS-authenticated account. Please keep the default private by using the existing “Private” option.

Prompt for AI agents 
Address the following comment on packages/nodes-base/nodes/Aws/S3/V1/BucketDescription.ts at line 97:

<comment>Defaulting the ACL to “authenticatedRead” means adding the optional ACL field without changing it will send `x-amz-acl: authenticated-read`, exposing the bucket’s contents to every AWS-authenticated account. Please keep the default private by using the existing “Private” option.</comment>

<file context>
@@ -94,7 +94,7 @@ export const bucketFields: INodeProperties[] = [
 					},
 				],
-				default: &#39;&#39;,
+				default: &#39;authenticatedRead&#39;,
 				description: &#39;The canned ACL to apply to the bucket&#39;,
 			},
</file context>
Fix with Cubic

description: 'The canned ACL to apply to the bucket',
},
{
Expand Down Expand Up @@ -281,7 +281,7 @@ export const bucketFields: INodeProperties[] = [
value: 'url',
},
],
default: '',
default: 'url',
description: 'Encoding type used by Amazon S3 to encode object keys in the response',
},
{
Expand Down
12 changes: 6 additions & 6 deletions packages/nodes-base/nodes/Aws/S3/V1/FileDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export const fileFields: INodeProperties[] = [
value: 'compliance',
},
],
default: '',
default: 'governance',
description: 'The Object Lock mode that you want to apply to this object',
},
{
Expand All @@ -207,7 +207,7 @@ export const fileFields: INodeProperties[] = [
value: 'replace',
},
],
default: '',
default: 'copy',
description:
'Specifies whether the metadata is copied from the source object or replaced with metadata provided in the request',
},
Expand All @@ -233,7 +233,7 @@ export const fileFields: INodeProperties[] = [
value: 'aws:kms',
},
],
default: '',
default: 'AES256',
description:
'The server-side encryption algorithm used when storing this object in Amazon S3',
},
Expand Down Expand Up @@ -321,7 +321,7 @@ export const fileFields: INodeProperties[] = [
value: 'replace',
},
],
default: '',
default: 'copy',
description:
'Specifies whether the metadata is copied from the source object or replaced with metadata provided in the request',
},
Expand Down Expand Up @@ -516,7 +516,7 @@ export const fileFields: INodeProperties[] = [
value: 'compliance',
},
],
default: '',
default: 'governance',
description: 'The Object Lock mode that you want to apply to this object',
},
{
Expand Down Expand Up @@ -555,7 +555,7 @@ export const fileFields: INodeProperties[] = [
value: 'aws:kms',
},
],
default: '',
default: 'AES256',
description:
'The server-side encryption algorithm used when storing this object in Amazon S3',
},
Expand Down
4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/Aws/S3/V2/BucketDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export const bucketFields: INodeProperties[] = [
value: 'publicReadWrite',
},
],
default: '',
default: 'authenticatedRead',
description: 'The canned ACL to apply to the bucket',
},
{
Expand Down Expand Up @@ -281,7 +281,7 @@ export const bucketFields: INodeProperties[] = [
value: 'url',
},
],
default: '',
default: 'url',
description: 'Encoding type used by Amazon S3 to encode object keys in the response',
},
{
Expand Down
12 changes: 6 additions & 6 deletions packages/nodes-base/nodes/Aws/S3/V2/FileDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export const fileFields: INodeProperties[] = [
value: 'compliance',
},
],
default: '',
default: 'governance',
description: 'The Object Lock mode that you want to apply to this object',
},
{
Expand All @@ -207,7 +207,7 @@ export const fileFields: INodeProperties[] = [
value: 'replace',
},
],
default: '',
default: 'copy',
description:
'Specifies whether the metadata is copied from the source object or replaced with metadata provided in the request',
},
Expand All @@ -233,7 +233,7 @@ export const fileFields: INodeProperties[] = [
value: 'aws:kms',
},
],
default: '',
default: 'AES256',
description:
'The server-side encryption algorithm used when storing this object in Amazon S3',
},
Expand Down Expand Up @@ -321,7 +321,7 @@ export const fileFields: INodeProperties[] = [
value: 'replace',
},
],
default: '',
default: 'copy',
description:
'Specifies whether the metadata is copied from the source object or replaced with metadata provided in the request',
},
Expand Down Expand Up @@ -516,7 +516,7 @@ export const fileFields: INodeProperties[] = [
value: 'compliance',
},
],
default: '',
default: 'governance',
description: 'The Object Lock mode that you want to apply to this object',
},
{
Expand Down Expand Up @@ -555,7 +555,7 @@ export const fileFields: INodeProperties[] = [
value: 'aws:kms',
},
],
default: '',
default: 'AES256',
description:
'The server-side encryption algorithm used when storing this object in Amazon S3',
},
Expand Down
Loading