Skip to content

ListenerSet adjust PortNumber kubebuilder validations #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

ListenerSet adjust PortNumber kubebuilder validations #3750

wants to merge 11 commits into from

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Apr 14, 2025 •
edited
Loading

  • set proper min/max value for listenerentry.port
  • adjust kubebuilder annotations for PortNumber to accomodate ListenerSet changes
PortNumber for ListenerEntry now supports setting to 0 - implying a port is randomly chosen by the implementation

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dprotaso
Once this PR has been reviewed and has the lgtm label, please assign youngnick for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/gep PRs related to Gateway Enhancement Proposal(GEP) size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 14, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2025
@dprotaso dprotaso changed the title [wip] adjust PortNumber kubebuilder validations ListenerSet adjust PortNumber kubebuilder validations Apr 17, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2025
dprotaso added a commit to dprotaso/gateway-api that referenced this pull request Apr 17, 2025
@dprotaso
Drop validation markers this is handled in another PR
64832c3 
See: kubernetes-sigs#3750
dprotaso added a commit to dprotaso/gateway-api that referenced this pull request Apr 17, 2025
@dprotaso
Drop validation markers this is handled in another PR
b1e12f7 
See: kubernetes-sigs#3750
dprotaso added a commit to dprotaso/gateway-api that referenced this pull request Apr 17, 2025
@dprotaso
Drop validation markers this is handled in another PR
8d6183c 
See: kubernetes-sigs#3750
@dprotaso dprotaso mentioned this pull request Apr 17, 2025
Open
@dprotaso dprotaso force-pushed the listenerset-port-number branch from f0f9284 to 2797f27 Compare April 17, 2025 05:41
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 17, 2025
@dprotaso
Copy link
Contributor Author

dprotaso commented May 6, 2025

bump

mlavacca
mlavacca reviewed May 7, 2025
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @dprotaso! Can we add some validation tests in https://github.com/kubernetes-sigs/gateway-api/blob/main/pkg/test/cel/httproute_standard_test.go, https://github.com/kubernetes-sigs/gateway-api/blob/main/pkg/test/cel/gateway_test.go and add new tests for ListenerSets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlavacca mlavacca mlavacca left review comments

@robscott robscott Awaiting requested review from robscott

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dprotaso @k8s-ci-robot @robscott @mlavacca