GEP-1713 Revisions #3744
Open
GEP-1713 Revisions #3744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
- Route attachment without sectionName - re-order policy attachment section - include a section about ReferenceGrants
dprotaso
force-pushed
the
gep-1713-revisions
branch
from
daaa5f1 to
c1eac08
Compare
|
cc @howardjohn |
We had to drop the use of the PortNumber type because of limitations with overriding min max using kubebuilder annotations
dprotaso
commented
Apr 14, 2025
youngnick
reviewed
Apr 15, 2025
youngnick
reviewed
Apr 15, 2025
youngnick
reviewed
Apr 15, 2025
|
Couple of small wording things, but aside from that, the GEP changes look good to me. The point about non-distinct |
Co-authored-by: Nick Young <[email protected]>
dprotaso
force-pushed
the
gep-1713-revisions
branch
from
64832c3 to
b1e12f7
Compare
dprotaso
force-pushed
the
gep-1713-revisions
branch
from
b1e12f7 to
8d6183c
Compare
|
I pulled the Port API changes into a separate PR - #3750 |
|
bump |
youngnick
reviewed
May 9, 2025
|
This LGTM now, so I'll approve. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@youngnick who should drop the hold? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind gep
What this PR does / why we need it:
As folks are implementing ListenerSets some clarifying questions came up and I thought it'd be good to revise the GEP with the answers.
Which issue(s) this PR fixes:
Fixes N/A
Does this PR introduce a user-facing change?: