Skip to content

Commit f0f9284

Browse files
committed
address linter warnings
1 parent fa3dcb4 commit f0f9284

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

pkg/generator/markers.go

+9-4
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ type Minimum float64
1010
func (m Minimum) Value() float64 {
1111
return float64(m)
1212
}
13+
14+
//nolint:unparam
1315
func (m Minimum) ApplyToSchema(schema *apiext.JSONSchemaProps) error {
1416
val := m.Value()
1517
schema.Minimum = &val
@@ -21,6 +23,8 @@ type Maximum float64
2123
func (m Maximum) Value() float64 {
2224
return float64(m)
2325
}
26+
27+
//nolint:unparam
2428
func (m Maximum) ApplyToSchema(schema *apiext.JSONSchemaProps) error {
2529
val := m.Value()
2630
schema.Maximum = &val
@@ -29,17 +33,18 @@ func (m Maximum) ApplyToSchema(schema *apiext.JSONSchemaProps) error {
2933

3034
// kubebuilder Min Max markers are broken with type aliases
3135
func registerMarkerOverrides(into *markers.Registry) {
32-
min, _ := markers.MakeDefinition(
36+
minMarker, _ := markers.MakeDefinition(
3337
"kubebuilder:validation:Minimum",
3438
markers.DescribesField,
3539
Minimum(0),
3640
)
3741

38-
max, _ := markers.MakeDefinition(
42+
maxMarker, _ := markers.MakeDefinition(
3943
"kubebuilder:validation:Maximum",
4044
markers.DescribesField,
4145
Maximum(0),
4246
)
43-
into.Register(min)
44-
into.Register(max)
47+
48+
into.Register(minMarker) //nolint:errcheck
49+
into.Register(maxMarker) //nolint:errcheck
4550
}

0 commit comments

Comments
 (0)