Skip to content

feat(esp_commands): add esp_commands component (IEC-338) #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(esp_commands): add esp_commands component (IEC-338) #530

wants to merge 3 commits into from

Conversation

SoucheSouche
Copy link
Collaborator

@SoucheSouche SoucheSouche commented Jul 25, 2025 •
edited
Loading

Checklist

  • Component contains License
  • Component contains README.md
  • Component contains idf_component.yml file with url field defined
  • Component was added to upload job
  • Component was added to build job
  • Optional: Component contains unit tests
  • CI passing

Change description

Please describe your change here

@SoucheSouche SoucheSouche marked this pull request as draft July 25, 2025 14:10
@github-actions github-actions bot changed the title feat(esp_commands): add esp_commands code feat(esp_commands): add esp_commands code (IEC-338) Jul 25, 2025
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch 3 times, most recently from 5154826 to a58eaa6 Compare July 31, 2025 08:42
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 31, 2025
View reviewed changes
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from a58eaa6 to 7aaddae Compare August 4, 2025 12:44
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 4, 2025
View reviewed changes
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from 7aaddae to 626c620 Compare August 5, 2025 07:43
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 5, 2025
View reviewed changes
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch 5 times, most recently from 916dbc7 to 7bb19c4 Compare August 5, 2025 11:46
ESP-Marius
ESP-Marius reviewed Aug 7, 2025
View reviewed changes
ESP-Marius
ESP-Marius reviewed Aug 7, 2025
View reviewed changes
@SoucheSouche SoucheSouche changed the title feat(esp_commands): add esp_commands code (IEC-338) feat(esp_commands): add esp_commands component (IEC-338) Aug 7, 2025
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from 7bb19c4 to cf00766 Compare August 7, 2025 11:51
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 7, 2025
View reviewed changes
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch 2 times, most recently from 7f8ef19 to 1469d38 Compare August 7, 2025 13:06
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 7, 2025
View reviewed changes
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from 1469d38 to 19173a7 Compare August 7, 2025 13:50
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 11, 2025
View reviewed changes
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from df4b49a to aa5a2ca Compare August 12, 2025 10:20
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 12, 2025
View reviewed changes
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from aa5a2ca to 253c3a7 Compare August 12, 2025 10:34
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 12, 2025
View reviewed changes
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from 253c3a7 to a70f444 Compare August 14, 2025 08:40
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 14, 2025
View reviewed changes
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from a70f444 to 20b701d Compare August 14, 2025 09:08
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 14, 2025
View reviewed changes
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from 20b701d to 9873ad4 Compare August 14, 2025 09:45
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 14, 2025
View reviewed changes
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch 5 times, most recently from 92b1065 to c1b8f4a Compare August 15, 2025 07:58
@SoucheSouche SoucheSouche marked this pull request as ready for review August 20, 2025 06:05
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch 2 times, most recently from 41b027d to db1c4ce Compare September 15, 2025 06:28
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from db1c4ce to 4388498 Compare September 26, 2025 09:06
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 1, 2025
View reviewed changes
esp_commands/esp_commands.c
return ESP_ERR_INVALID_ARG;
}

memcpy(&s_config, config, sizeof(s_config));

Check warning

Code scanning / clang-tidy

Call to function 'memcpy' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memcpy_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning

Call to function 'memcpy' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memcpy_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
esp_commands/esp_commands.c
*/
FDPRINTF(fd_out, "%-s", it->name);
if (it->hint_cb) {
FDPRINTF(fd_out, " %s\n", it->hint_cb(it->func_ctx));

Check warning

Code scanning / clang-tidy

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
esp_commands/esp_commands.c
if (it->hint_cb) {
FDPRINTF(fd_out, " %s\n", it->hint_cb(it->func_ctx));
} else {
FDPRINTF(fd_out, "\n");

Check warning

Code scanning / clang-tidy

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
esp_commands/esp_commands.c
* help cmd_name -v 0 */
if (argc <= 0 || argc > 4) {
/* unknown issue, return error */
FDPRINTF(fd_out, "help: invalid number of arguments %d\n", argc);

Check warning

Code scanning / clang-tidy

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
esp_commands/esp_commands.c
/* check if the following argument is either 0, or 1 */
if (i + 1 >= argc) {
/* format error, return with error */
FDPRINTF(fd_out, "help: arguments not provided in the right format\n");

Check warning

Code scanning / clang-tidy

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
esp_commands/esp_commands.c
verbose_level = 1;
} else {
/* wrong command format, return error */
FDPRINTF(fd_out, "help: invalid verbose level %s\n", argv[i + 1]);

Check warning

Code scanning / clang-tidy

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
esp_commands/esp_commands.c
go_through_commands(cmd_sets, &ctx, call_command_funcs);

if (command_name && !ctx.command_found) {
FDPRINTF(fd_out, "help: invalid command name %s\n", command_name);

Check warning

Code scanning / clang-tidy

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch 4 times, most recently from d8ce859 to 448dec2 Compare October 2, 2025 12:04
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 2, 2025
View reviewed changes
esp_commands/esp_commands.c
/* First line: command name and hint
* Pad all the hints to the same column
*/
FDPRINTF(fd_out, "%-s", it->name);

Check warning

Code scanning / clang-tidy

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
esp_commands/esp_commands.c
/* TODO: replace the simple print with a function that
* replaces arg_print_formatted */
if (it->help) {
FDPRINTF(fd_out, " %s\n", it->help);

Check warning

Code scanning / clang-tidy

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
esp_commands/esp_commands.c
if (it->help) {
FDPRINTF(fd_out, " %s\n", it->help);
} else {
FDPRINTF(fd_out, " -\n");

Check warning

Code scanning / clang-tidy

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
esp_commands/esp_commands.c

static void print_arg_command(const int fd_out, esp_command_t *it)
{
FDPRINTF(fd_out, "%-s", it->name);

Check warning

Code scanning / clang-tidy

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from 448dec2 to 5f20bcc Compare October 2, 2025 12:12
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 2, 2025
View reviewed changes
esp_commands/esp_commands.c
if (it->hint_cb) {
const char *hint = it->hint_cb(it->func_ctx);
if (hint) {
FDPRINTF(fd_out, " %s", it->hint_cb(it->func_ctx));

Check warning

Code scanning / clang-tidy

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
esp_commands/esp_commands.c
}
}

FDPRINTF(fd_out, "\n");

Check warning

Code scanning / clang-tidy

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning

Call to function 'snprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'snprintf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ESP-Marius ESP-Marius ESP-Marius left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Status: Reviewing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SoucheSouche @ESP-Marius @espressif-bot