Add SendableTransaction type
#482
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ec1907d The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced May 8, 2025
Merged
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
BundleMonFiles updated (7)
Unchanged files (120)
Total files change +85B +0.02% Final result: ✅ View report in BundleMon website ➡️ |
|
Documentation Preview: https://kit-docs-5nkxpp0xj-anza-tech.vercel.app |
lorisleiva
force-pushed
the
05-08-add_sendabletransaction_type
branch
from
56e29d2 to
9c23a11
Compare
steveluscher
approved these changes
May 8, 2025
There was a problem hiding this comment.
Absolutely not important, but I wonder if we can do better than ‘sendable,’ mostly because everything is sendable. I can send whatever junk I want to the network. Whether it's *****able by the network or not is the question this name tries to answer.
- Processable?
- Landable?
- Executable?
- Acceptable?
- Ingestible?
- Admissible?
- Comittable?
lorisleiva
force-pushed
the
05-07-refactor_fullysignedtransaction_helpers
branch
from
b433163 to
aee8ba5
Compare
lorisleiva
force-pushed
the
05-08-add_sendabletransaction_type
branch
from
9c23a11 to
5431523
Compare
lorisleiva
force-pushed
the
05-07-refactor_fullysignedtransaction_helpers
branch
from
aee8ba5 to
8049329
Compare
lorisleiva
force-pushed
the
05-08-add_sendabletransaction_type
branch
from
5431523 to
2725d93
Compare
|
@steveluscher I thought about this for a while and perhaps something like |
lorisleiva
force-pushed
the
05-07-refactor_fullysignedtransaction_helpers
branch
from
8049329 to
f0467c6
Compare
lorisleiva
force-pushed
the
05-08-add_sendabletransaction_type
branch
from
2725d93 to
6e3e968
Compare
lorisleiva
force-pushed
the
05-07-refactor_fullysignedtransaction_helpers
branch
from
f0467c6 to
f5461ca
Compare
lorisleiva
force-pushed
the
05-08-add_sendabletransaction_type
branch
from
6e3e968 to
33b6f6b
Compare
lorisleiva
force-pushed
the
05-08-add_sendabletransaction_type
branch
from
33b6f6b to
b1d71bd
Compare
lorisleiva
force-pushed
the
05-07-refactor_fullysignedtransaction_helpers
branch
from
f5461ca to
811b8db
Compare
lorisleiva
changed the base branch from
05-07-refactor_fullysignedtransaction_helpers
to
graphite-base/482
lorisleiva
force-pushed
the
graphite-base/482
branch
from
811b8db to
b9ae938
Compare
lorisleiva
force-pushed
the
05-08-add_sendabletransaction_type
branch
from
b1d71bd to
8a5802f
Compare
lorisleiva
changed the base branch from
graphite-base/482
to
05-06-make_fullysignedtransaction_composable
lorisleiva
force-pushed
the
05-06-make_fullysignedtransaction_composable
branch
from
b9ae938 to
d6e404c
Compare
lorisleiva
force-pushed
the
05-08-add_sendabletransaction_type
branch
2 times, most recently
from
57cfad3 to
a8f2ba0
Compare
lorisleiva
force-pushed
the
05-06-make_fullysignedtransaction_composable
branch
2 times, most recently
from
18f6e43 to
f796886
Compare
lorisleiva
force-pushed
the
05-08-add_sendabletransaction_type
branch
from
a8f2ba0 to
356d914
Compare
lorisleiva
force-pushed
the
05-06-make_fullysignedtransaction_composable
branch
2 times, most recently
from
8c3b97e to
8042266
Compare
lorisleiva
force-pushed
the
05-08-add_sendabletransaction_type
branch
from
356d914 to
0f9c310
Compare
lorisleiva
force-pushed
the
05-08-add_sendabletransaction_type
branch
from
0f9c310 to
ec1907d
Compare
lorisleiva
added
the
do-not-close
mcintyre94
approved these changes
Jun 9, 2025
| This type represents a transaction that has all the required conditions to be sent to the network. Namely: | ||
|
|
||
| - It must be fully signed (ie. conform to `FullySignedTransaction`) | ||
| - It must be within size limit (ie. conform to `TransactionWithSizeLimit`) |
There was a problem hiding this comment.
Should TransactionWithSizeLimit have a section in the readme too?
| TransactionWithinSizeLimit satisfies SendableTransaction; | ||
| } | ||
|
|
||
| // It does not satify Transaction alone. |
There was a problem hiding this comment.
Suggested change
| // It does not satify Transaction alone. | |
| // It is not satisfied by Transaction alone. |
I think this is a clearer way to word the relationship here
| null as unknown as Transaction satisfies SendableTransaction; | ||
| } | ||
|
|
||
| // It does not satify Transaction with missing required conditions. |
There was a problem hiding this comment.
Suggested change
| // It does not satify Transaction with missing required conditions. | |
| // It is not satisfied by Transaction with missing required conditions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now have more than one condition for a transaction to be sendable — i.e.
FullySignedTransactionandTransactionWithinSizeLimit— this PR introduces a new umbrella type calledSendableTransactionthat contains all the type "flags" required for a transaction be sent to the network.