Skip to content

Refactor FullySignedTransaction helpers #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Refactor FullySignedTransaction helpers #479

merged 1 commit into from
May 14, 2025

Conversation

lorisleiva
Copy link
Member

@lorisleiva lorisleiva commented May 7, 2025 •
edited
Loading

This PR renames assertTransactionIsFullySigned to assertIsFullySignedTransaction and adds a new isFullySignedTransaction helper. This helps keep our naming consistent across the library.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 7, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 11c510e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@solana/transactions Minor
@solana/compat Minor
@solana/kit Minor
@solana/react Minor
@solana/rpc-api Minor
@solana/rpc-graphql Minor
@solana/rpc-subscriptions-api Minor
@solana/signers Minor
@solana/transaction-confirmation Minor
@solana/rpc Minor
@solana/sysvars Minor
@solana/rpc-subscriptions Minor
@solana/accounts Minor
@solana/addresses Minor
@solana/assertions Minor
@solana/codecs-core Minor
@solana/codecs-data-structures Minor
@solana/codecs-numbers Minor
@solana/codecs-strings Minor
@solana/codecs Minor
@solana/errors Minor
@solana/fast-stable-stringify Minor
@solana/functional Minor
@solana/instructions Minor
@solana/keys Minor
@solana/nominal-types Minor
@solana/options Minor
@solana/programs Minor
@solana/promises Minor
@solana/rpc-parsed-types Minor
@solana/rpc-spec-types Minor
@solana/rpc-spec Minor
@solana/rpc-subscriptions-channel-websocket Minor
@solana/rpc-subscriptions-spec Minor
@solana/rpc-transformers Minor
@solana/rpc-transport-http Minor
@solana/rpc-types Minor
@solana/subscribable Minor
@solana/transaction-messages Minor
@solana/webcrypto-ed25519-polyfill Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This was referenced May 7, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
@lorisleiva Graphite App
Copy link
Member Author

lorisleiva commented May 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lorisleiva lorisleiva mentioned this pull request May 7, 2025
Merged
@lorisleiva lorisleiva marked this pull request as ready for review May 7, 2025 12:45
@bundlemon BundleMon
Copy link

bundlemon bot commented May 7, 2025 •
edited
Loading

BundleMon

Files updated (4)
Status Path Size Limits
✅ transactions/dist/index.browser.mjs
 2.27KB (+55B +2.43%) -
✅ transactions/dist/index.node.mjs
 2.26KB (+55B +2.43%) -
✅ transactions/dist/index.native.mjs
 2.27KB (+54B +2.38%) -
✅ @solana/kit production bundle
kit/dist/index.production.min.js
 34.39KB (+44B +0.13%) -
Unchanged files (123)
Status Path Size Limits
✅ rpc-graphql/dist/index.browser.mjs
 18.78KB -
✅ rpc-graphql/dist/index.native.mjs
 18.78KB -
✅ rpc-graphql/dist/index.node.mjs
 18.78KB -
✅ errors/dist/index.node.mjs
 14.54KB -
✅ errors/dist/index.browser.mjs
 14.52KB -
✅ errors/dist/index.native.mjs
 14.52KB -
✅ transaction-messages/dist/index.browser.mjs
 7.24KB -
✅ transaction-messages/dist/index.native.mjs
 7.24KB -
✅ transaction-messages/dist/index.node.mjs
 7.24KB -
✅ codecs-data-structures/dist/index.native.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.browser.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.node.mjs
 4.77KB -
✅ webcrypto-ed25519-polyfill/dist/index.node.mj
s
 3.57KB -
✅ webcrypto-ed25519-polyfill/dist/index.browser
.mjs
 3.56KB -
✅ webcrypto-ed25519-polyfill/dist/index.native.
mjs
 3.54KB -
✅ rpc-subscriptions/dist/index.browser.mjs
 3.38KB -
✅ rpc-subscriptions/dist/index.node.mjs
 3.34KB -
✅ rpc-subscriptions/dist/index.native.mjs
 3.31KB -
✅ codecs-core/dist/index.browser.mjs
 3.3KB -
✅ codecs-core/dist/index.native.mjs
 3.3KB -
✅ codecs-core/dist/index.node.mjs
 3.3KB -
✅ rpc-transformers/dist/index.browser.mjs
 2.93KB -
✅ rpc-transformers/dist/index.native.mjs
 2.93KB -
✅ rpc-transformers/dist/index.node.mjs
 2.93KB -
✅ addresses/dist/index.browser.mjs
 2.86KB -
✅ addresses/dist/index.native.mjs
 2.86KB -
✅ addresses/dist/index.node.mjs
 2.86KB -
✅ kit/dist/index.browser.mjs
 2.71KB -
✅ kit/dist/index.native.mjs
 2.71KB -
✅ kit/dist/index.node.mjs
 2.71KB -
✅ signers/dist/index.browser.mjs
 2.63KB -
✅ signers/dist/index.native.mjs
 2.63KB -
✅ signers/dist/index.node.mjs
 2.62KB -
✅ codecs-strings/dist/index.browser.mjs
 2.53KB -
✅ codecs-strings/dist/index.node.mjs
 2.48KB -
✅ codecs-strings/dist/index.native.mjs
 2.45KB -
✅ transaction-confirmation/dist/index.node.mjs
 2.4KB -
✅ sysvars/dist/index.browser.mjs
 2.35KB -
✅ sysvars/dist/index.native.mjs
 2.34KB -
✅ transaction-confirmation/dist/index.native.mj
s
 2.34KB -
✅ sysvars/dist/index.node.mjs
 2.34KB -
✅ transaction-confirmation/dist/index.browser.m
js
 2.34KB -
✅ rpc-subscriptions-spec/dist/index.node.mjs
 2.13KB -
✅ rpc-subscriptions-spec/dist/index.native.mjs
 2.08KB -
✅ rpc-subscriptions-spec/dist/index.browser.mjs
 2.08KB -
✅ keys/dist/index.browser.mjs
 2.02KB -
✅ keys/dist/index.native.mjs
 2.02KB -
✅ keys/dist/index.node.mjs
 2.02KB -
✅ codecs-numbers/dist/index.native.mjs
 2.01KB -
✅ codecs-numbers/dist/index.browser.mjs
 2.01KB -
✅ codecs-numbers/dist/index.node.mjs
 2.01KB -
✅ react/dist/index.native.mjs
 1.99KB -
✅ react/dist/index.browser.mjs
 1.99KB -
✅ react/dist/index.node.mjs
 1.99KB -
✅ rpc/dist/index.node.mjs
 1.95KB -
✅ rpc-transport-http/dist/index.browser.mjs
 1.91KB -
✅ rpc-transport-http/dist/index.native.mjs
 1.91KB -
✅ rpc/dist/index.native.mjs
 1.8KB -
✅ subscribable/dist/index.node.mjs
 1.8KB -
✅ rpc/dist/index.browser.mjs
 1.8KB -
✅ subscribable/dist/index.native.mjs
 1.75KB -
✅ subscribable/dist/index.browser.mjs
 1.74KB -
✅ rpc-transport-http/dist/index.node.mjs
 1.73KB -
✅ rpc-types/dist/index.browser.mjs
 1.53KB -
✅ rpc-types/dist/index.native.mjs
 1.53KB -
✅ rpc-types/dist/index.node.mjs
 1.53KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.node.mjs
 1.33KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.native.mjs
 1.27KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.browser.mjs
 1.26KB -
✅ options/dist/index.browser.mjs
 1.18KB -
✅ options/dist/index.native.mjs
 1.18KB -
✅ options/dist/index.node.mjs
 1.17KB -
✅ accounts/dist/index.browser.mjs
 1.13KB -
✅ accounts/dist/index.native.mjs
 1.12KB -
✅ accounts/dist/index.node.mjs
 1.12KB -
✅ compat/dist/index.browser.mjs
 971B -
✅ compat/dist/index.native.mjs
 970B -
✅ compat/dist/index.node.mjs
 968B -
✅ rpc-spec-types/dist/index.browser.mjs
 964B -
✅ rpc-api/dist/index.browser.mjs
 963B -
✅ rpc-api/dist/index.native.mjs
 962B -
✅ rpc-spec-types/dist/index.native.mjs
 962B -
✅ rpc-api/dist/index.node.mjs
 961B -
✅ rpc-spec-types/dist/index.node.mjs
 961B -
✅ rpc-subscriptions-api/dist/index.native.mjs
 870B -
✅ rpc-subscriptions-api/dist/index.node.mjs
 869B -
✅ rpc-subscriptions-api/dist/index.browser.mjs
 868B -
✅ rpc-spec/dist/index.browser.mjs
 829B -
✅ rpc-spec/dist/index.native.mjs
 829B -
✅ rpc-spec/dist/index.node.mjs
 828B -
✅ promises/dist/index.browser.mjs
 799B -
✅ promises/dist/index.native.mjs
 798B -
✅ promises/dist/index.node.mjs
 797B -
✅ assertions/dist/index.browser.mjs
 783B -
✅ instructions/dist/index.browser.mjs
 769B -
✅ instructions/dist/index.native.mjs
 768B -
✅ instructions/dist/index.node.mjs
 767B -
✅ fast-stable-stringify/dist/index.browser.mjs
 726B -
✅ fast-stable-stringify/dist/index.native.mjs
 725B -
✅ assertions/dist/index.native.mjs
 724B -
✅ fast-stable-stringify/dist/index.node.mjs
 724B -
✅ assertions/dist/index.node.mjs
 723B -
✅ programs/dist/index.browser.mjs
 329B -
✅ programs/dist/index.native.mjs
 327B -
✅ programs/dist/index.node.mjs
 325B -
✅ event-target-impl/dist/index.node.mjs
 233B -
✅ functional/dist/index.browser.mjs
 154B -
✅ functional/dist/index.native.mjs
 152B -
✅ text-encoding-impl/dist/index.native.mjs
 152B -
✅ functional/dist/index.node.mjs
 151B -
✅ codecs/dist/index.browser.mjs
 137B -
✅ codecs/dist/index.native.mjs
 136B -
✅ codecs/dist/index.node.mjs
 134B -
✅ event-target-impl/dist/index.browser.mjs
 133B -
✅ ws-impl/dist/index.node.mjs
 131B -
✅ text-encoding-impl/dist/index.browser.mjs
 122B -
✅ text-encoding-impl/dist/index.node.mjs
 119B -
✅ crypto-impl/dist/index.node.mjs
 114B -
✅ ws-impl/dist/index.browser.mjs
 113B -
✅ crypto-impl/dist/index.browser.mjs
 109B -
✅ rpc-parsed-types/dist/index.browser.mjs
 66B -
✅ rpc-parsed-types/dist/index.native.mjs
 65B -
✅ rpc-parsed-types/dist/index.node.mjs
 63B -

Total files change +201B +0.06%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025 •
edited
Loading

Documentation Preview: https://kit-docs-943potfc8-anza-tech.vercel.app

@lorisleiva lorisleiva force-pushed the 05-07-refactor_fullysignedtransaction_helpers branch from fbad903 to b6e4837 Compare May 8, 2025 15:02
@lorisleiva lorisleiva force-pushed the 05-06-use_transactionmessagewithinsizelimit_in_helper_functions branch from 0128277 to c1b833d Compare May 8, 2025 15:15
@lorisleiva lorisleiva force-pushed the 05-07-refactor_fullysignedtransaction_helpers branch 2 times, most recently from 3941581 to d7ab026 Compare May 8, 2025 15:43
@lorisleiva lorisleiva force-pushed the 05-06-use_transactionmessagewithinsizelimit_in_helper_functions branch from c1b833d to d2c1252 Compare May 8, 2025 15:43
@lorisleiva lorisleiva force-pushed the 05-07-refactor_fullysignedtransaction_helpers branch from d7ab026 to b433163 Compare May 8, 2025 15:53
@lorisleiva lorisleiva force-pushed the 05-06-use_transactionmessagewithinsizelimit_in_helper_functions branch from d2c1252 to a9d2409 Compare May 8, 2025 15:53
@lorisleiva lorisleiva mentioned this pull request May 8, 2025
Open
steveluscher
steveluscher approved these changes May 8, 2025
View reviewed changes
Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

@lorisleiva lorisleiva force-pushed the 05-07-refactor_fullysignedtransaction_helpers branch from b433163 to aee8ba5 Compare May 8, 2025 21:40
@lorisleiva lorisleiva force-pushed the 05-06-use_transactionmessagewithinsizelimit_in_helper_functions branch 2 times, most recently from 1ff66ef to d55aa07 Compare May 8, 2025 21:52
@lorisleiva lorisleiva force-pushed the 05-07-refactor_fullysignedtransaction_helpers branch from aee8ba5 to 8049329 Compare May 8, 2025 21:53
@lorisleiva lorisleiva force-pushed the 05-07-refactor_fullysignedtransaction_helpers branch from 8049329 to f0467c6 Compare May 12, 2025 10:04
@lorisleiva lorisleiva force-pushed the 05-06-use_transactionmessagewithinsizelimit_in_helper_functions branch 2 times, most recently from 6ec858e to f780cb8 Compare May 12, 2025 10:17
@lorisleiva lorisleiva force-pushed the 05-07-refactor_fullysignedtransaction_helpers branch from f0467c6 to f5461ca Compare May 12, 2025 10:17
@lorisleiva lorisleiva mentioned this pull request May 12, 2025
Merged
@lorisleiva lorisleiva force-pushed the 05-07-refactor_fullysignedtransaction_helpers branch from f5461ca to 811b8db Compare May 14, 2025 08:31
@lorisleiva lorisleiva force-pushed the 05-06-use_transactionmessagewithinsizelimit_in_helper_functions branch 2 times, most recently from 2311a56 to d205506 Compare May 14, 2025 08:57
@lorisleiva lorisleiva force-pushed the 05-07-refactor_fullysignedtransaction_helpers branch 2 times, most recently from 8327a4a to 997881e Compare May 14, 2025 09:01
@lorisleiva lorisleiva force-pushed the 05-06-use_transactionmessagewithinsizelimit_in_helper_functions branch from d205506 to 61c1f71 Compare May 14, 2025 09:01
@lorisleiva lorisleiva force-pushed the 05-07-refactor_fullysignedtransaction_helpers branch from 997881e to e42c9e7 Compare May 14, 2025 09:30
@lorisleiva Graphite App
Copy link
Member Author

lorisleiva commented May 14, 2025 •
edited
Loading

Merge activity

  • May 14, 5:56 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 14, 6:27 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 14, 6:30 AM EDT: @lorisleiva merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from 05-06-use_transactionmessagewithinsizelimit_in_helper_functions to graphite-base/479 May 14, 2025 10:23
@lorisleiva lorisleiva changed the base branch from graphite-base/479 to main May 14, 2025 10:26
@lorisleiva lorisleiva force-pushed the 05-07-refactor_fullysignedtransaction_helpers branch from e42c9e7 to 11c510e Compare May 14, 2025 10:27
@lorisleiva lorisleiva merged commit bbcb913 into main May 14, 2025
14 checks passed
@lorisleiva lorisleiva deleted the 05-07-refactor_fullysignedtransaction_helpers branch May 14, 2025 10:30
@github-actions github-actions bot mentioned this pull request May 14, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveluscher steveluscher steveluscher approved these changes

@mcintyre94 mcintyre94 Awaiting requested review from mcintyre94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorisleiva @steveluscher