Add transaction size helpers #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 867e852 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced May 1, 2025
BundleMonFiles updated (7)
Unchanged files (120)
Total files change +1.07KB +0.31% Final result: ✅ View report in BundleMon website ➡️ |
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
from
0825090 to
f33ef5d
Compare
steveluscher
approved these changes
May 5, 2025
There was a problem hiding this comment.
For instance: adding an instruction to or changing the lifetime of a transaction message should remove the
TransactionMessageUnderSizeLimittype
I think this is only true when you're going from not-nonce to nonce. Otherwise the size of the transaction should stay the same or decrease.
| Lifetime before | Lifetime after | Should remove TransactionMessageUnderSizeLimit |
|---|---|---|
| None | Blockhash | ❌ |
| None | Nonce | ✅ |
| Blockhash | Nonce | ✅ |
| Blockhash | Blockhash | ❌ |
| Blockhash | None | ❌ |
| Nonce | Nonce | ❌ |
| Nonce | Blockhash | ❌ |
| Nonce | None | ❌ |
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
from
f33ef5d to
18f576a
Compare
|
@steveluscher I'm a little confused by your table. Could the second half of it be a bad copy/paste? |
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
from
18f576a to
243b7f6
Compare
|
I don't think so! Essentially all blockhash-based transactions will be the same size, even one that has ‘no’ blockhash, because all that changes is the choice of 32 lifetime specifier bytes in the message, but never the number of bytes. If a nonce transaction used to have an acceptable size, it will always have an acceptable size if it changes to a blockhash-based one, because the only thing that could have happened is that the If a nonce transaction used to have an acceptable size, it will still have an acceptable size given a new choice of nonce; while the choice of lifetime specifier and |
|
Oh so sorry, my brain could categorically not see the difference between "Nonce" and "None" on that table. Makes a lot more sense now. I'll definitely keep that in mind when I add this logic in subsequent PRs. |
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
from
243b7f6 to
89bf30d
Compare
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
2 times, most recently
from
5aeb05a to
af2e039
Compare
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
from
af2e039 to
437f9f8
Compare
Merged
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
from
437f9f8 to
e9d78a5
Compare
|
Documentation Preview: https://kit-docs-1lgwzynj4-anza-tech.vercel.app |
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
from
e9d78a5 to
dbbc080
Compare
lorisleiva
changed the base branch from
graphite-base/425
to
05-06-fix_signers_typetest_filenames
lorisleiva
force-pushed
the
05-06-fix_signers_typetest_filenames
branch
from
6982c44 to
c8b5fda
Compare
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
2 times, most recently
from
87bbf91 to
4e54279
Compare
lorisleiva
force-pushed
the
05-06-fix_signers_typetest_filenames
branch
from
c8b5fda to
82ecc10
Compare
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
from
4e54279 to
a864afe
Compare
lorisleiva
force-pushed
the
05-06-fix_signers_typetest_filenames
branch
from
82ecc10 to
e659cfc
Compare
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
from
a864afe to
630dd47
Compare
lorisleiva
changed the base branch from
05-06-fix_signers_typetest_filenames
to
graphite-base/425
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
from
630dd47 to
f3093e0
Compare
lorisleiva
force-pushed
the
graphite-base/425
branch
from
e659cfc to
3049e01
Compare
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
3 times, most recently
from
f3093e0 to
56aa6ee
Compare
lorisleiva
force-pushed
the
05-01-add_transaction_size_helpers
branch
from
56aa6ee to
867e852
Compare
Merge activity
|
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds various types and functions to help get the size of a transaction (or its message) and ensure its size is valid (under the transaction size limit).
Additionally, it provides two new types —
TransactionUnderSizeLimitandTransactionMessageUnderSizeLimit— to provide additional type safety before sending a transaction.In this PR,
TransactionUnderSizeLimitandTransactionMessageUnderSizeLimitare only used by their respective type guards but this stack of PR aims to use these types to offer more type safety in other parts of the code. For instance: adding an instruction to or changing the lifetime of a transaction message should remove theTransactionMessageUnderSizeLimittype if any; sending a transaction should require theTransactionUnderSizeLimit; compiling aTransactionMessageUnderSizeLimitinto a transaction should return aTransactionUnderSizeLimit; etc.The next few PRs don't do any of that just yet but prepare the field for such changes. Mainly, it aims to bring more consistency amongst the type flags of transactions and transaction messages so adding yet another one does not affect the developer experience.