Skip to content

Conversation

@Kevinlzh9802
Copy link
Contributor

Switch python version 2 to 3.
Although initial test with test.py failed, I believe all necessary changes have been made to switch the python version, and the error is unrelated with the version update.

@Kevinlzh9802 Kevinlzh9802 added the enhancement New feature or request label May 2, 2025
Copy link
Contributor

@Era-Dorta Era-Dorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, just one minor optional comment.

import sys
import struct
import Queue
import queue
Copy link
Contributor

@Era-Dorta Era-Dorta May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about importing it like this? Does that makes more sense and make the code leaner?

Suggested change
import queue
from queue import Queue

If so, can you do the same for the other files?

@Era-Dorta
Copy link
Contributor

I forgot to add, can you please update the readme so that it says to install python 3 instead of python 2?

@Era-Dorta
Copy link
Contributor

@Josfemova, @harshilbhatt2001, fyi, this updates the code from python 2 to python 3.

Copy link
Contributor

@Era-Dorta Era-Dorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon further testing this fails due to encoding bytes / strings changes in python 2 / 3. Still needs fixing.

@Era-Dorta Era-Dorta moved this to Optional in midge-code S1 2025 May 8, 2025
@Era-Dorta Era-Dorta moved this from Optional to In Progress in midge-code S1 2025 May 8, 2025
@Era-Dorta
Copy link
Contributor

This introduces delays and breaks in the connection. This might explain why the connection is so slow and bad with the switch to bleak. I've been debugging a bit but I've haven't figured out yet why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants