-
Notifications
You must be signed in to change notification settings - Fork 3
Python2to3 #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Python2to3 #30
Conversation
Era-Dorta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, just one minor optional comment.
| import sys | ||
| import struct | ||
| import Queue | ||
| import queue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about importing it like this? Does that makes more sense and make the code leaner?
| import queue | |
| from queue import Queue |
If so, can you do the same for the other files?
|
I forgot to add, can you please update the readme so that it says to install python 3 instead of python 2? |
|
@Josfemova, @harshilbhatt2001, fyi, this updates the code from python 2 to python 3. |
Era-Dorta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon further testing this fails due to encoding bytes / strings changes in python 2 / 3. Still needs fixing.
|
This introduces delays and breaks in the connection. This might explain why the connection is so slow and bad with the switch to bleak. I've been debugging a bit but I've haven't figured out yet why. |
Switch python version 2 to 3.
Although initial test with
test.pyfailed, I believe all necessary changes have been made to switch the python version, and the error is unrelated with the version update.