add new audio parse script with timestamp decoding #29
Conversation
| if current_pos + buffer_frames > len(audio_data): | ||
| buffer_frames = len(audio_data) - current_pos | ||
|
|
||
| if buffer_frames <= 0: |
There was a problem hiding this comment.
Can you explain when is this condition true? I don't quite understand it.
There was a problem hiding this comment.
Rather than adding decoding the audio file here. Can you remove the audio decoding function and import the metadata functions into the existing audio parser file and add an if statement that if a ".d" file exists then it also does the timestamp decoding and otherwise it doesn't? Otherwise, we have code duplication.
|
|
||
| # Convert timestamps to datetime for readability | ||
| base_time = datetime.fromtimestamp(timestamps[0]) | ||
| df['datetime'] = [base_time + timedelta(seconds=(t - timestamps[0])) for t in timestamps] |
There was a problem hiding this comment.
I think this is wrong, why are you turning them into time deltas? The time stamps already have the full date and time.
There was a problem hiding this comment.
I wrote it before the changed to the midge code were finalised. Now, I'm just waiting for #30 to go through before I fix this.
There was a problem hiding this comment.
Do you mind fixing it with python 2? VSCode doesn't work with python2 but pycharm does. So you can code it there. The update in #30 is turned out more complicated that I thought, somehow the update is breaking the connection as I wrote in #30 (comment)
There was a problem hiding this comment.
Alright. I'll close this PR for now then
Fix #25