-
Notifications
You must be signed in to change notification settings - Fork 143
Random blocks in structures #1793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Random blocks in structures #1793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to know the performance impact of this, both in absolute numbers and relative to the previous cost of generating these particular models.
Compared to everything else, the performance impact is negligible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this some more, and I don't think this goes far enough.
Maybe the next person wants to have a striped pattern (→we already have this hardcoded for the biome stone type), or a spherical pattern with respect to the structure source (you mentioned craters), or a noise distribution, or a block structure depending on the distance to the surface.
If this really is relatively cheap in the overall biome generation cost, then I think we can afford a VTable here, and if you keep the single-block version as a separate kind then we might end up even cheaper than what you have implemented here.
Also it would need some kind of "generate entire column" option in the VTable if we want to apply it efficiently to the biome stone type.
Another thing to add to the list of things we'd want: random selection per biome/structure, like currently for the crystal caves. |
Ok, I want this very badly for jungle biome. |
Allows specifying a selection of multiple blocks in simple structures:

