-
Notifications
You must be signed in to change notification settings - Fork 160
Jungle #1930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Jungle #1930
Conversation
I would appreciate #1793 for this so we can properly mix monsteras, ferns, grass and flowers 😄 |
The trees look amazing. The giant ones are very treehouse worthy. |
Jungle tweaks
There is some work to left:
I don't think splitting I won't include what Carrie said in this list, so to not duplicate it, but it very much applies. I would appreciate if someone could have a look at subbiomes, because honestly I was only interested in making trees :3 |
I can do some subbiomes. |
@Argmaster I made a PR for subbiomes |
Jungle subbiomes
![]() ![]() ![]() ![]() I think I am happy with the outcome and I will give up on further changes in the trees unless requested as necessary. Biome variants @careeoki made are super cool and they improved the jungle a lot. Monstera, also made by @careeoki, turned out to be an absolute game changer when it comes to making jungle feel like an actual jungle. Addressing @ikabod-kee concerns with wood collection, I have added quite a few fallen trees, additionally 2x2 trees are very very easy to cut down as you can make circle staircase through them and walk on the branches. If we allowed climbing the ivy it would improve even further. Short trees are fairly simple to cut down as they are in your reach all the time, while tall trees are tall trees and are awkward to cut down. Well, typical, can't do much about the last. I did some testing how it would feel if leaves had no hitboxes and in my opinion this is totally viable with addition of branches. It is very cool that you can climb to the top of the tree through branches. I encourage you to try that, its a lot of fun. I won't force that change in this PR but I would like to open (or re-open) this discussion. (screenshots were made on version 0.0.0 thus old fern) |
Thank you for including fallen logs for wood collection :) It should help players out a lot |
You should totally make a seperare PR for no-collision leaves. Is it possible right now for leafy branches to only have collison on the branch parts? |
I couldn't get this to work, it will probably be possible with #1821 though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I think you nailed the ground level. Also adding ancient structures is nice too.
There is that problem with the roots, but I would keep the roots since they add a lot to the atmosphere. We can figure out a solution or workaround for the root problem at a later point.
The only thing that I do not like is how repetitive the tree tops look, particularly in the ancient jungle
I'd suggest to add asome optional extenders into the stem and between the two leaf levels to give it some more variety in heigth.
.{.old = "desert", .new = "desert/base"}, | ||
.{.old = "forest", .new = "forest/base"}, | ||
.{.old = "jungle(TODO)", .new = "jungle"}, | ||
.{.old = "jungle", .new = "jungle/base"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new entries at the bottom please.
.properties = .{ | ||
.wet, | ||
.hot, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be moved into _defaults
This proposal contains a proposal of jungle improvements.
Additionally it contains monstera plant created @careeoki which is heavily used in new jungle.