Return geometry by value (alternative 3) #891
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blattms
added
the
manual:enhancement
|
jenkjns build this please |
|
jenkins build this please |
aritorto
reviewed
Jul 14, 2025
Closed
SoilRos
force-pushed
the
bugfix/return-geometry-by-value-3
branch
2 times, most recently
from
9a8a719 to
9799277
Compare
|
jenkins build this serial please |
This is to conform with the dune interface
To avoid copying a shared pointer, which is rather costly, the geometry now stores the corners holding either the ownership of the entity variables.
SoilRos
force-pushed
the
bugfix/return-geometry-by-value-3
branch
from
9799277 to
deba814
Compare
|
jenkins build this serial please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the idea is that the geometry holds all the corners of the cell. This because in most of the cases, the geometry is constructed in place and the compiler theoretically could see through the things that are actually needed and only generate code for that. In other words, it would avoid making the copy if those values are not used.
Here is a benchmark for that hypothesis: https://quick-bench.com/q/IPXA-MuhVrdQ_9DSbgbcAyRW9ek
Note that this PR is based on #885 which fixes all the lifetime issues of the geometry objects.