Skip to content

Conversation

aritorto
Copy link
Member

@aritorto aritorto commented Jul 14, 2025

Only for testing changes to fix all failing lgr tests in #891

SoilRos added 2 commits July 4, 2025 12:24
This is to conform with the dune interface
To avoid copying a shared pointer, which is rather costly, the geometry now stores the corners holding either the ownership of the entity variables.
@aritorto aritorto added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Jul 14, 2025
@aritorto aritorto marked this pull request as draft July 14, 2025 10:14
@aritorto
Copy link
Member Author

jenkins build this serial please

@aritorto aritorto changed the title Copy pr891 Copy PR891 Jul 14, 2025
@aritorto
Copy link
Member Author

benchmark please

@blattms
Copy link
Member

blattms commented Jul 15, 2025

Seems like I need to do it for now.

@ytelses
Copy link

ytelses commented Jul 15, 2025

Benchmark result overview:

Test Configuration Relative
opm-git OPM Benchmark: drogon - Threads: 1 1.004
opm-git OPM Benchmark: drogon - Threads: 8 0.905
opm-git OPM Benchmark: punqs3 - Threads: 1 0.991
opm-git OPM Benchmark: punqs3 - Threads: 8 0.995
opm-git OPM Benchmark: smeaheia - Threads: 1 0.895
opm-git OPM Benchmark: smeaheia - Threads: 8 0.997
opm-git OPM Benchmark: spe10_model_1 - Threads: 1 0.992
opm-git OPM Benchmark: spe10_model_1 - Threads: 8 0.995
opm-git OPM Benchmark: flow_mpi_extra - Threads: 1 0.948
opm-git OPM Benchmark: flow_mpi_extra - Threads: 8 1.026
opm-git OPM Benchmark: flow_mpi_norne - Threads: 1 1.002
opm-git OPM Benchmark: flow_mpi_norne - Threads: 8 1.007
opm-git OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 1 - FOPT (Total Oil Production At End Of Run) 1
opm-git OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 8 - FOPT (Total Oil Production At End Of Run) 1
  • Speed-up = Total time master / Total time pull request. Above 1.0 is an improvement. *

View result details @ https://www.ytelses.com/opm/?page=result&id=2824

@SoilRos
Copy link
Member

SoilRos commented Jul 31, 2025

@aritorto Thanks for taking a look into this, I already pushed this change into the original branch in #891.

@SoilRos SoilRos closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants