Revert entity test with geometry #904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entity has no knowledge of the grid, hence, it cannot create a geometry so it segfaults. This test may work when the compiler manages to figure out that the geometry object is not really needed and can create the geometry on the fly. This may explain why this was not trigger in the CI.
SoilRos
added
the
manual:irrelevant
SoilRos
commented
Jul 31, 2025
| BOOST_CHECK_EQUAL(referenceElement(e5.geometry()).type(), e5.type()); | ||
|
|
||
| // Cannot check other members without a real grid. | ||
| // Put in more checks when it is possible to construct |
There was a problem hiding this comment.
This is my bad, I didn't read this comment until now. But it pretty much explains why I should not have used the geometry here.
There was a problem hiding this comment.
Good point. I should have noticed that, so my bad too...
|
jenkins build this serial please |
aritorto
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entity has no knowledge of the grid, hence, it cannot create a geometry so it segfaults. This test may work when the compiler manages to figure out that the geometry object is not really needed and can create the geometry on the fly. This may explain why this was not trigger in the CI.
This produces failures in other PRs like #885 #884 and #891