Bump React Native to 0.79 #60421

war-in · 2025-04-17T11:20:15Z

Explanation of Change

Short summary of added/removed patches

Removed:

@react-native+virtualized-lists+0.77.1+001+onStartReched.patch
expo-image-manipulator+13.0.6+002+fix-type-exports.patch
expo-modules-core+2.2.3+002+change-global-type.patch
jest-expo+52.0.3.patch
react-native+0.77.1+022+disable-suggestion-pop-up.patch
react-native+0.77.1+023+dont-enable-height-centering.patch

Added:

@react-ng+bounds-observer+0.2.1.patch - support for React 19, mostly removing propsTypes and findNodeHandle usages
react-native+0.79.2+024+restore-old-line-height-algorithm.patch - instead of react-native+0.77.1+023+dont-enable-height-centering.patch (we should get rid of it in a followup PR)
react-native-google-places-autocomplete+2.5.6+001+react-19-support.patch - support for React 19, removing propTypes, upstream PR: fix: get default props issue FaridSafi/react-native-google-places-autocomplete#970
react-native-reanimated+3.17.1+006+fix-crashing-build-variants.patch - fixing build crash, upstream PR: fix: add hermes debugger for all debug variants software-mansion/react-native-reanimated#7428
react-native-web+0.20.0+010+restore-findNodeHandle.patch - fixing findNodeHandle usages on web

Fixed Issues

$ #57511
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13535

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…/rn-79-update

…-in/rn-79-update

github-actions · 2025-04-17T11:20:28Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-18T09:57:04Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-18T10:09:47Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-18T10:20:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/60421/NewExpensify.dmg	https://60421.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

github-actions · 2025-04-18T11:06:07Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-22T12:46:38Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-22T13:26:52Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-22T14:08:48Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/60421-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/60421-hybrid/index.html

Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

github-actions · 2025-04-22T15:10:13Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-22T15:16:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	https://60421.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

github-actions · 2025-04-22T16:56:10Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-22T17:37:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/60421-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/60421-hybrid/index.html

Desktop 💻	Web 🕸️
❌ FAILED ❌	https://60421.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

# Conflicts: # jest/setup.ts # package-lock.json # package.json

shubham1206agra · 2025-06-17T12:35:48Z

@WoLewicki Can you fix the errors here?

shubham1206agra · 2025-06-17T17:42:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

shubham1206agra

Going to approve to kick things off

mountiny · 2025-06-19T20:04:45Z

Going to merge this before the weekend or on Monday

# Conflicts: # package-lock.json

melvin-bot · 2025-06-23T15:52:11Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

roryabraham · 2025-06-23T15:53:39Z

ignoring changed files lint to limit the risk of this already-huge PR
validatePatches is being handled separately: https://expensify.slack.com/archives/C08CZDJFJ77/p1750668397801589?thread_ts=1750160780.408569&cid=C08CZDJFJ77

OSBotify · 2025-06-23T16:02:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mountiny

Lets go! Thanks for the effort on this one @war-in

mkzie2 · 2025-06-24T05:46:29Z

validatePatches is being handled separately: https://expensify.slack.com/archives/C08CZDJFJ77/p1750668397801589?thread_ts=1750160780.408569&cid=C08CZDJFJ77

Hi @war-in @roryabraham Coming from #64457, I modified a patch there. Can you let me know how the react-native patches should be cleaned up as you mentioned above? Just to avoid conflicts that are hard to resolve.

mkzie2 · 2025-06-24T05:54:02Z

I intended to follow what the guidelines here suggested. Specifically:

Move all react-native patches to under patches/react-native folder
Create details.md file explaining what my own patch react-native+0.79.2+011+Add-onPaste-to-TextInput.patch does; and leave the rest patches as // TODO. It should look like this 7c16a53

Does that sound reasonable?

mateuuszzzzz · 2025-06-24T07:30:01Z

validatePatches is being handled separately: https://expensify.slack.com/archives/C08CZDJFJ77/p1750668397801589?thread_ts=1750160780.408569&cid=C08CZDJFJ77

Hi @war-in @roryabraham Coming from #64457, I modified a patch there. Can you let me know how the react-native patches should be cleaned up as you mentioned above? Just to avoid conflicts that are hard to resolve.

Hi, I'm handling the cleanup of existing React Native patches in a separate PR. However, I think it's fine to add a details.md file with a description of your new patch. Just please make sure that changing the directory structure of the react-native patches doesn’t introduce any regressions to the artifacts workflow.

github-actions · 2025-06-24T19:16:55Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.71-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-27T23:10:37Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.71-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

eh2077 · 2025-09-29T10:10:14Z

There seems no upstream issue for the @react-ng/bounds-observer patch.

war-in added 4 commits April 16, 2025 16:02

Merge branch 'refs/heads/war-in/migrate-documents-picker' into war-in…

982fcaf

…/rn-79-update

Merge branch 'refs/heads/war-in/pre-78/bump-gesture-handler' into war…

34aaa63

…-in/rn-79-update

minimal changes to run all platforms

9fc7294

Merge branch 'main' into war-in/rn-79-update

308ad45

war-in added 5 commits April 18, 2025 09:15

fix FocusTrap crash

ae78853

log warning when findNodeHandle used

f704dc4

rename patches

273c442

remove Batchinator from jest setup (it has been removed from RN)

334393b

fix gh actions

bc73948

This comment has been minimized.

Sign in to view

mountiny assigned war-in Apr 19, 2025

war-in added 3 commits April 22, 2025 11:39

Merge branch 'main' into war-in/rn-79-update

c493cb3

bump live-markdown & airship

a3a6e44

fix .ref usages

b25db8a

This was referenced Apr 22, 2025

[Due for payment 2025-07-04] [Due for payment 2025-06-18] Upgrade React Native to 0.79 #57511

Closed

[Pre RN 0.79] Bump react-native-live-markdown #60664

Merged

war-in added 2 commits April 23, 2025 10:32

Merge branch 'main' into war-in/rn-79-update

4e0306a

# Conflicts: # jest/setup.ts # package-lock.json # package.json

fix settings screen

f3779e6

Fix typecheck after main merge

4521379

shubham1206agra approved these changes Jun 17, 2025

View reviewed changes

melvin-bot bot requested a review from roryabraham June 17, 2025 17:49

war-in added 3 commits June 23, 2025 11:02

Merge branch 'main' into war-in/rn-79-update

00ca57e

# Conflicts: # package-lock.json

fix typecheck & package-lock

db43b21

fix generateTranslations.ts

ea82762

roryabraham approved these changes Jun 23, 2025

View reviewed changes

roryabraham merged commit bf3017c into Expensify:main Jun 23, 2025
25 of 27 checks passed

melvin-bot bot added the Emergency label Jun 23, 2025

roryabraham removed the Emergency label Jun 23, 2025

mountiny approved these changes Jun 23, 2025

View reviewed changes

mkzie2 mentioned this pull request Jun 24, 2025

fix: pasting from wps office crashes app #64457

Merged

51 tasks

github-actions bot mentioned this pull request Jun 24, 2025

Deploy Checklist: New Expensify 2025-06-24 #64820

Closed

mountiny mentioned this pull request Jun 24, 2025

Migrate App’s VideoPlayer from Deprecated expo-av to expo-video #64846

Open

mountiny mentioned this pull request Jul 1, 2025

[Due for payment 2025-08-22] [$1000] Update patches after the react native update #65284

Closed

linhvovan29546 mentioned this pull request Jul 4, 2025

[Due for payment 2025-08-05] [$250] iOS - Chat - Expand button does not appear in composer when entering multiline text #64900

Closed

8 tasks

This was referenced Jul 22, 2025

Delete restore-old-line-height-algorithm React Native patch #66869

Merged

Delete restore-old-line-height-algorithm React Native patch v2 #67176

Merged

Bump React Native to 0.79 #60421

Bump React Native to 0.79 #60421

Uh oh!

Conversation

war-in commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Apr 17, 2025

Uh oh!

github-actions bot commented Apr 18, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Apr 18, 2025

Uh oh!

github-actions bot commented Apr 18, 2025

Uh oh!

github-actions bot commented Apr 18, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

shubham1206agra commented Jun 17, 2025

Uh oh!

shubham1206agra commented Jun 17, 2025

Reviewer Checklist

Uh oh!

shubham1206agra left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jun 19, 2025

Uh oh!

Uh oh!

melvin-bot bot commented Jun 23, 2025

Uh oh!

roryabraham commented Jun 23, 2025

Uh oh!

OSBotify commented Jun 23, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mkzie2 commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkzie2 commented Jun 24, 2025

Uh oh!

mateuuszzzzz commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

eh2077 commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

war-in commented Apr 17, 2025 •

edited

Loading

mkzie2 commented Jun 24, 2025 •

edited

Loading

mateuuszzzzz commented Jun 24, 2025 •

edited

Loading