fix: pasting from wps office crashes app #64457

mkzie2 · 2025-06-18T15:31:03Z

Explanation of Change

This PR fixes:

Pasting text from WPS Office crashes the app
Pasting text from Google Docs does not work

`details.md`

### [react-native+0.79.2+011+Add-onPaste-to-TextInput.patch](react-native+0.79.2+011+Add-onPaste-to-TextInput.patch)

- Reasons:
    - Adds `onPaste` callback to `TextInput` to support image pasting on native
    - Fixes an issue where pasted image displays as binary text on some Android devices where rich clipboard data is stored in binary form
    - Fixes an issue where pasting from WPS Office app crashes the app on Android where its content URI is not recognized by Android `ContentResolver`
- Upstream PR/issue: https://github.com/facebook/react-native/pull/45425
- Upstream RFC: https://github.com/s77rt/discussions-and-proposals/blob/TextInput-onPaste/proposals/0000-textinput-onpaste.md
- E/App issue:
    - https://github.com/Expensify/App/issues/41239
    - https://github.com/Expensify/App/issues/55304
    - https://github.com/Expensify/App/issues/63191
- PR Introducing Patch: [#47203](https://github.com/Expensify/App/pull/47203)

Fixed Issues

$ #63191
PROPOSAL: #63191 (comment)

Tests

Copy plain text from WPS Office app
Long press Expensify report composer > Paste
Verify app does not crash and text is pasted
Copy plain text from Google Docs app (the doc must be shared publicly)
Long press Expensify report composer > Paste
Verify text is pasted
Copy image/chart from Google Docs app (the doc must be shared publicly)
Long press Expensify report composer > Paste
Verify image/chart is pasted

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Copy plain text from WPS Office app
Long press Expensify report composer > Paste
Verify app does not crash and text is pasted

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Google Docs text & image:

Screenrecording_20250625_124519.mp4

Screenrecording_20250625_124448.mp4

WPS text:

Screenrecording_20250625_124341.mp4

Android: mWeb Chrome

Screenrecording_20250625_125507.mp4

iOS: Native

RPReplay_Final1750831938.mov

iOS: mWeb Safari

RPReplay_Final1750831521.mov

RPReplay_Final1750831653.mov

RPReplay_Final1750831809.mov

MacOS: Chrome / Safari

Untitled.mov

Screen.Recording.2025-06-25.at.13.44.07.mov

Screen.Recording.2025-06-25.at.13.50.12-compressed.mov

Screen.Recording.2025-06-25.at.13.49.17-compressed.mov

MacOS: Desktop

Screen.Recording.2025-06-25.at.13.46.27-compressed.mov

Screen.Recording.2025-06-25.at.13.50.34-compressed.mov

…/63191

github-actions · 2025-06-18T15:31:14Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

mkzie2 · 2025-06-18T17:07:21Z

Android build kept failing for me. Asked on Slack here.

…/63191

melvin-bot · 2025-06-23T18:09:35Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mkzie2 · 2025-06-23T18:10:10Z

I'm still stuck with Android build #64457 (comment). @cead22 Can you help to trigger adhoc builds for this PR?

github-actions · 2025-06-23T22:14:17Z

🚧 @cead22 has triggered a test Expensify/App build. You can view the workflow run here.

cead22 · 2025-06-23T22:54:08Z

@mkzie2 it looks like that error is known (https://expensify.slack.com/archives/C01GTK53T8Q/p1750696354220979) and it'll be fixed soon. Can you merge main in the mean time?

…/63191

mkzie2 · 2025-06-23T23:05:25Z

This is not done. We just upgraded to RN 0.79.2. I need to verify the patches.

…/63191

mkzie2 · 2025-06-24T07:55:49Z

@cead22 Can you please re-trigger the adhoc builds? Thanks!

mkzie2 · 2025-06-24T07:58:36Z

@cead22 @jayeshmangwani I think we can ignore the Validate Patches check because it's being handled elsewhere #60421 (comment), #60421 (comment). It is not straight forward and related to the artifacts workflow which is out of scope of this PR.

@mateuuszzzzz Hi, I already included the description of the modified patch in PR description. Please help me to include it in your clean-up PR in case my PR got merged first. Thanks!

github-actions · 2025-06-24T18:59:27Z

🚧 @cead22 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-06-24T22:06:50Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #64457.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/64457/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/64457/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/64457/NewExpensify.dmg	https://64457.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mkzie2 · 2025-06-25T06:53:08Z

The builds worked well. I added the recordings. @jayeshmangwani You can start your review now. Note that pasting image from WPS Office is not supported on native apps yet (while Google Docs does).

jayeshmangwani · 2025-06-26T11:12:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mp4

Android: mWeb Chrome

mweb-chrome.mp4

iOS: HybridApp

iOS.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani · 2025-06-27T06:12:46Z

@mkzie2 There are a few inconsistencies when copying images from WPS Office. This might be a separate issue from the crash, but I just want to confirm before approving this PR. Copying and pasting images from WPS behaves differently on Android and mobile web (Chrome).

wps-android.mp4

jayeshmangwani · 2025-07-02T09:53:55Z

@cead22 Tested the build on Android - it's working well when copying both image and text; no crashes observed.

Please refer to comment #64457 (comment) for details on the inconsistency. There are some issues when copying from WPS Office - specifically, images copied from WPS don't paste properly into the Android composer. I also tested on mobile Chrome (web), and it throws an error after copying from WPS, so it's not working there either (production version).

That said, these issues appear to be unrelated to this PR, which specifically addresses the crash. I’ll report those bugs separately, but I'm noting them here for visibility.

cead22 · 2025-07-03T00:12:47Z

patches/react-native+0.79.2+011+Add-onPaste-to-TextInput.patch

-+          data = itemUri.toString();
-+          if (mPasteWatcher != null) {
-+            mPasteWatcher.onPaste(type, data);
+          if (type != null && !type.equals(ClipDescription.MIMETYPE_TEXT_PLAIN)) {


The indentation in this patch seems off, does it matter?

It looks fine on my side:

Oh yeah the green and red background in the GH diff is confusing on these patches

cead22 · 2025-07-03T18:13:59Z

The validate patches GHA is still failing

cead22 · 2025-07-07T22:46:50Z

Any updates?

mkzie2 · 2025-07-07T22:51:45Z

@cead22 The validate patches GHA failure is expected for now. See #64457 (comment).

@mateuuszzzzz Can you confirm that the react-native patches cleanup and details.md for them are being worked on elsewhere? I already included mine in the PR description for you to add later. Thanks!

cead22 · 2025-07-08T16:14:55Z

@cead22 The validate patches GHA failure is expected for now. See #64457 (comment).

Should we disable it for now until it's fixed, instead of ignoring it in every PR?

mkzie2 · 2025-07-08T21:40:16Z

The check would only be triggered on changed files which rarely happens given it's related to 3rd-party lib patches. Maybe @roryabraham could suggest a better way here.

TL;DR I updated a react-native patch and the Validate Patches action failed because it's missing details.md. But as you mentioned, the react-native patches cleanup is being handled elsewhere #60421 (comment). Should we ignore that failed check for this PR?

roryabraham · 2025-07-11T21:32:56Z

Ah, yes I agree that we can ignore the failing validatePatches check here. Thanks @mkzie2 for providing a well-formed details.md entry in the PR description. Ultimately validatePatches is about enforcing proper documentation of patches so that we can understand why they were added and better track their lifecycle. The description you provided gives that context and can be easily ported into #63324. 👍🏼

I also brought this up in slack to get #63324 finished soon.

Should we disable it for now until it's fixed, instead of ignoring it in every PR?

@cead22 for context, the check is only non-trivial to fix if we modify patches of certain dependencies that have multiple patches, such as react-native, react-native-web, and react-native-reanimated. So I think it's valuable to keep it enabled in the meantime, because if someone adds a new patch for a currently-unpatched dependency, we'd enforce that the required documentation is collected.

cead22 · 2025-07-14T18:34:36Z

@roryabraham thanks for the context, and @mkzie2 @jayeshmangwani sorry for the delay in the review. Can you merge main to resolve the conflicts, and I'll approve and merge? Thanks

roryabraham · 2025-07-14T19:29:09Z

FWIW, #63324 is merged now, so after merging main and resolving conflicts, validatePatches should pass.

…/63191

OSBotify · 2025-07-17T00:45:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-18T05:13:04Z

🚀 Deployed to staging by https://github.com/cead22 in version: 9.1.83-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-21T16:36:57Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.83-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mkzie2 added 2 commits June 18, 2025 22:26

fix: pasting from wps office crashes app

c5f5d53

Merge branch 'main' of github.com-mkzie2:mkzie2/App into mkzie2-issue…

fd9ffe4

…/63191

tidy up react-native patches

e374a33

mkzie2 added 2 commits June 19, 2025 00:15

fill in the remaining patches

7c16a53

Merge branch 'main' of github.com-mkzie2:mkzie2/App into mkzie2-issue…

b32dc90

…/63191

mkzie2 marked this pull request as ready for review June 23, 2025 18:09

mkzie2 requested a review from a team as a code owner June 23, 2025 18:09

melvin-bot bot requested review from jayeshmangwani and removed request for a team June 23, 2025 18:09

This comment has been minimized.

Sign in to view

Merge branch 'main' of github.com-mkzie2:mkzie2/App into mkzie2-issue…

e15df8d

…/63191

mkzie2 mentioned this pull request Jun 24, 2025

Bump React Native to 0.79 #60421

Merged

50 tasks

mkzie2 added 8 commits June 24, 2025 12:48

revert improper merge commit

300aa75

revert

1e57843

Merge branch 'main' of github.com-mkzie2:mkzie2/App into mkzie2-issue…

390c63c

…/63191

create patch

1cff511

tidy up react-native patches

8da5fb0

rename patches

7379de7

rename patches

5c54abe

revert: tidy up react-native patches

a848d24

jayeshmangwani approved these changes Jul 2, 2025

View reviewed changes

melvin-bot bot requested a review from cead22 July 2, 2025 09:50

cead22 reviewed Jul 3, 2025

View reviewed changes

cead22 previously approved these changes Jul 3, 2025

View reviewed changes

Merge branch 'main' of github.com-mkzie2:mkzie2/App into mkzie2-issue…

581bf35

…/63191

mkzie2 dismissed cead22’s stale review via 581bf35 July 15, 2025 06:22

add details.md entry for patch

504c2d7

cead22 approved these changes Jul 17, 2025

View reviewed changes

cead22 merged commit c97352a into Expensify:main Jul 17, 2025
16 checks passed

github-actions bot mentioned this pull request Jul 18, 2025

Deploy Checklist: New Expensify 2025-07-18 #66687

Closed

72 tasks

melvin-bot bot mentioned this pull request Jul 21, 2025

[Due for payment 2025-07-28] [$250] Android - Chat - App crash when paste text or image that was copied from WPS Office #63191

Closed

16 tasks

jayeshmangwani mentioned this pull request Jul 28, 2025

fix: binary content appears in composer when pasting image #60501

Merged

50 tasks

fix: pasting from wps office crashes app #64457

fix: pasting from wps office crashes app #64457

Uh oh!

Conversation

mkzie2 commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

details.md

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

mkzie2 commented Jun 18, 2025

Uh oh!

melvin-bot bot commented Jun 23, 2025

Uh oh!

mkzie2 commented Jun 23, 2025

Uh oh!

github-actions bot commented Jun 23, 2025

Uh oh!

This comment has been minimized.

cead22 commented Jun 23, 2025

Uh oh!

mkzie2 commented Jun 23, 2025

Uh oh!

mkzie2 commented Jun 24, 2025

Uh oh!

mkzie2 commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

mkzie2 commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayeshmangwani commented Jun 26, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani commented Jun 27, 2025

Uh oh!

jayeshmangwani commented Jul 2, 2025

Uh oh!

cead22 Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

mkzie2 Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

cead22 Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

cead22 commented Jul 3, 2025

Uh oh!

cead22 commented Jul 7, 2025

Uh oh!

mkzie2 commented Jul 7, 2025

Uh oh!

cead22 commented Jul 8, 2025

Uh oh!

mkzie2 commented Jul 8, 2025

Uh oh!

roryabraham commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cead22 commented Jul 14, 2025

Uh oh!

roryabraham commented Jul 14, 2025

Uh oh!

Uh oh!

OSBotify commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

mkzie2 commented Jun 18, 2025 •

edited

Loading

`details.md`

mkzie2 commented Jun 24, 2025 •

edited

Loading

mkzie2 commented Jun 25, 2025 •

edited

Loading

roryabraham commented Jul 11, 2025 •

edited

Loading