-
Notifications
You must be signed in to change notification settings - Fork 551
Replaces our lighting system with CM's. #21465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NonQueueingMatt
wants to merge
52
commits into
Aurorastation:master
Choose a base branch
from
NonQueueingMatt:wont_you_turn_the_light_on
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Replaces our lighting system with CM's. #21465
NonQueueingMatt
wants to merge
52
commits into
Aurorastation:master
from
NonQueueingMatt:wont_you_turn_the_light_on
+3,798
−3,048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # code/modules/mob/living/silicon/robot/robot_helpers.dm
1 task
1 task
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
… wont_you_turn_the_light_on
…ight_on # Conflicts: # aurorastation.dme # code/__DEFINES/layers.dm # code/__HELPERS/emissives.dm # code/controllers/subsystems/zcopy.dm # code/game/atoms_movable.dm # code/game/objects/effects/shockwave.dm # code/modules/multiz/zmimic/mimic_movable.dm # code/modules/power/lights/fixtures.dm # code/modules/rendering/plane_master.dm # code/modules/rendering/render_plate.dm # maps/sccv_horizon/sccv_horizon.dmm
|
Conflicts have been resolved. Mark the PR as ready for review again if it is ready to be reviewed. |
0baa97d to
0f2e80c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
⚠ High Risk
Reasonable chance of causing many or high-severity bugs.
Javascript
Pull requests that update Javascript code.
🗺️ Mapping - Away Ship/Away Site
The PR touches away ship and/or away site map files.
🗺️ Mapping - Event
The PR touches event map files.
🗺️ Mapping - Horizon
The PR touches the Horizon map files.
🗺️ Mapping - Random Ruins
The PR touches random ruins map files.
Sprites
Adds new or changes existing sprites.
Test Merge Candidate
The PR is eligible for test merging.
TGUI
Tools
WIP
The PR is a work in progress and should not be reviewed yet.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #21458.
Ports cmss13-devs/cmss13#4229, with the original authors as:
The main driving reason behind this is that current lighting consumes way too much processing power, especially for things like odysseys/away sites where a billion light sources are processing/moving at once and the game slows down to a crawl. Hopefully this improves the situation by a good margin, but we will need some testmerging to confirm that.

