Clear stat cache in FileCache::set()

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ## 3.1.1 under development
 
-- no changes in this release.
+- Bug #85: Clear stat cache in `FileCache::set()` (@samdark)
 
 ## 3.1.0 October 09, 2023
 

src/FileCache.php

@@ -89,7 +89,7 @@
      */
     public function __construct(
         private string $cachePath,
         private int $directoryMode = 0775,
     ) {
         if (!$this->createDirectoryIfNotExists($cachePath)) {
             throw new CacheException("Failed to create cache directory \"$cachePath\".");
@@ -132,10 +132,10 @@
             throw new CacheException("Failed to create cache directory \"$cacheDirectory\".");
         }
 
-        // If ownership differs the touch call will fail, so we try to
+        // If ownership differs, the touch call will fail, so we try to
         // rebuild the file from scratch by deleting it first
         // https://github.com/yiisoft/yii2/pull/16120
         if (function_exists('posix_geteuid') && is_file($file) && fileowner($file) !== posix_geteuid()) {
             @unlink($file);
         }
 
@@ -150,7 +150,12 @@
             }
         }
 
-        $result = @touch($file, $expiration);
+        $result = false;
+
+        if (@touch($file, $expiration)) {
+            clearstatcache();
+            $result = true;
+        }
 
         return $this->isLastErrorSafe($result);
     }
@@ -197,7 +202,7 @@
             $this->set((string) $key, $value, $ttl);
         }
 
         return true;
     }
 
     public function deleteMultiple(iterable $keys): bool
@@ -209,7 +214,7 @@
             $this->delete($key);
         }
 
         return true;
     }
 
     public function has(string $key): bool
@@ -332,7 +337,7 @@
             return true;
         }
 
         $result = !is_file($path) && mkdir(directory: $path, recursive: true) && is_dir($path);
 
         if ($result) {
             chmod($path, $this->directoryMode);

tests/FileCacheTest.php

@@ -647,4 +647,22 @@ private function removeDirectory(string $directory): void
 
         rmdir($directory);
     }
+
+    public function testSetClearsStatCache(): void
+    {
+        $this->cache->set(__FUNCTION__, 'cache1', 2);
+
+        $refClass = new \ReflectionClass($this->cache);
+        $refMethodGetCacheFile = $refClass->getMethod('getCacheFile');
+        $refMethodGetCacheFile->setAccessible(true);
+        $cacheFile = $refMethodGetCacheFile->invoke($this->cache, __FUNCTION__);
+
+        // simulate cache expire 10 seconds ago
+        touch($cacheFile, time() - 10);
+        clearstatcache();
+
+        $this->assertNull($this->cache->get(__FUNCTION__));
+        $this->assertTrue($this->cache->set(__FUNCTION__, 'cache2', 2));
+        $this->assertSame('cache2', $this->cache->get(__FUNCTION__));
+    }
 }