Clear stat cache in FileCache::set() #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
samdark
commented
Dec 30, 2024
samdark
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | yiisoft/yii2#20304 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
============================================
+ Coverage 90.96% 91.13% +0.17%
- Complexity 71 72 +1
============================================
Files 1 1
Lines 155 158 +3
============================================
+ Hits 141 144 +3
Misses 14 14 ☔ View full report in Codecov by Sentry. |
terabytesoftw
approved these changes
Dec 30, 2024
xepozz
approved these changes
Dec 30, 2024
vjik
requested changes
Dec 30, 2024
Co-authored-by: Sergei Predvoditelev <[email protected]>
Member
Author
|
@vjik good ideas. Thanks. Applied. |
vjik
reviewed
Dec 30, 2024
Do not pass parameters to `clearstatcache()`
vjik
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.