Skip to content

Update protobuf-java to 4.32.1 #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update protobuf-java to 4.32.1 #4039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,7 @@ lazy val benchmark =
// "com.thesamet.scalapb" %% "scalapb-runtime-grpc" % scalapb.compiler.Version.scalapbVersion
// For grpc-java
"io.grpc" % "grpc-protobuf" % GRPC_VERSION,
"com.google.protobuf" % "protobuf-java" % "3.25.8",
"com.google.protobuf" % "protobuf-java" % "4.32.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update to protobuf-java version 4.32.1 is incorrect and will cause issues. According to the official Protocol Buffers documentation, the 4.x releases are for Java Lite and C# users, while regular Java users should stick to the 3.x series. This project uses grpc-protobuf version 1.75.0, which depends on protobuf-java version 3.25.3. Introducing protobuf-java 4.x will create a version conflict and lead to binary incompatibilities, likely resulting in NoSuchMethodError or other LinkageErrors at runtime. This change should be reverted. It would be best to close this PR and configure Scala Steward to ignore this and future 4.x updates for protobuf-java.

("com.chatwork" %% "scala-ulid" % "1.0.24").cross(CrossVersion.for3Use2_13)
)
// Compile / PB.targets := Seq(
Expand Down
Loading