-
Notifications
You must be signed in to change notification settings - Fork 70
Update protobuf-java to 4.32.1 #4039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a critical dependency upgrade, bringing the protobuf-java
library to its latest major version. This update is essential for incorporating the most recent features, performance enhancements, and security fixes from the Protobuf ecosystem, ensuring the project remains current and robust.
Highlights
- Dependency Update: Updated the
com.google.protobuf:protobuf-java
dependency from version3.25.8
to4.32.1
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. β©
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request proposes an update to protobuf-java
from a 3.x version to 4.32.1
. This update is incorrect and should not be merged. The 4.x series of protobuf-java
is not a successor to the 3.x series for standard Java projects; it's intended for Java Lite. This project's dependency grpc-java
relies on the 3.x series of protobuf-java
, so this update would introduce binary incompatibilities and cause runtime errors. I recommend closing this PR and configuring Scala Steward to ignore this update path.
// For grpc-java | ||
"io.grpc" % "grpc-protobuf" % GRPC_VERSION, | ||
"com.google.protobuf" % "protobuf-java" % "3.25.8", | ||
"com.google.protobuf" % "protobuf-java" % "4.32.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update to protobuf-java
version 4.32.1
is incorrect and will cause issues. According to the official Protocol Buffers documentation, the 4.x releases are for Java Lite and C# users, while regular Java users should stick to the 3.x series. This project uses grpc-protobuf
version 1.75.0
, which depends on protobuf-java
version 3.25.3
. Introducing protobuf-java
4.x will create a version conflict and lead to binary incompatibilities, likely resulting in NoSuchMethodError
or other LinkageError
s at runtime. This change should be reverted. It would be best to close this PR and configure Scala Steward to ignore this and future 4.x updates for protobuf-java
.
About this PR
π¦ Updates com.google.protobuf:protobuf-java from
3.25.8
to4.32.1
βUsage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: