Skip to content

Feature/rooms first response time and protocol #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feature/rooms first response time and protocol #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion chats/apps/api/v1/internal/rooms/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class Meta:
"first_response_time",
"waiting_time",
"queue_time",
"protocol",
]

def get_agent(self, obj):
Expand Down Expand Up @@ -69,7 +70,7 @@ def get_duration(self, obj: Room) -> int:

def get_first_response_time(self, obj: Room) -> int:
try:
if hasattr(obj, "metric") and obj.metric.first_response_time > 0:
if hasattr(obj, "metric") and obj.metric.first_response_time is not None:
return obj.metric.first_response_time

if obj.first_user_assigned_at and obj.is_active and obj.user:
Expand Down
12 changes: 8 additions & 4 deletions chats/apps/dashboard/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,14 @@ def calculate_first_response_time(room: "Room") -> int:
if not room.first_user_assigned_at:
return 0

first_agent_message = room.messages.filter(
user__isnull=False,
created_on__gte=room.first_user_assigned_at
).order_by("created_on").first()
first_agent_message = (
room.messages.filter(
user__isnull=False, created_on__gte=room.first_user_assigned_at
)
.exclude(automatic_message__isnull=False)
.order_by("created_on")
.first()
)

if not first_agent_message:
return 0
Expand Down