-
Notifications
You must be signed in to change notification settings - Fork 50
Add proof chain and set documentation to credential issuance #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proof chain and set documentation to credential issuance #503
Conversation
@bparth24 Still not quite right, you have to make sure the author is set to the right value for each commit. Given the commits you've done, we'd have to manually go through each commit to assign provenance instead of just using the commit author field. We have a script to do the tallying automatically based on git author (not commit message, which we can't depend on because of the varied way that people do commit comments). You will want to do something like:
Also, please use a consistent commit message format: https://github.com/digitalbazaar/bedrock/blob/main/CONTRIBUTING.md#commit-messages |
c817e55
to
961b721
Compare
|
yes, please do. Ideally, all commits should follow that format. |
- Defines three approaches for handling existing proofs: Proof Sets, Proof Chains, and Error Handling - Clarifies behavior when credentials already contain proofs Addresses w3c-ccg#422
- Improves sentence structure and clarity throughout the section Addresses w3c-ccg#422
- Enhances technical precision in proof handling descriptions Addresses w3c-ccg#422
961b721
to
2026200
Compare
@msporny I understood and updated the commit messages. |
Excellent! LGTM, merging. |
This PR addresses #422 by clarifying how the
/credentials/issue
endpoint handles credentials with existing proofs as agreed upon in the 2025-05-27 call.Background
This PR replaces PR #495, which had corrupted commit history due to a rebase issue that lost proper attribution. I apologize for my mistake - this clean branch preserves everyone's contributions with correct authorship.
Individual Contributions
📋 Changes Made
Enhanced Issue Credential section to document three configuration-based behaviors:
Clarified instance configuration determines proof processing behavior
Note
This replaces PR #495 due to commit history corruption. All improvements are preserved here with proper attribution.
If merged it will close: #422 and replaces: PR #495. In any case PR #495 should be closed right away.
@dlongley @msporny @TallTed - ready for review & merge.
Preview | Diff