-
Notifications
You must be signed in to change notification settings - Fork 50
[DO NOT MERGE] Add proof chain and set documentation to credential issuance #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dlongley thanks for the input. It makes sense to me. |
Group discussed on 7/22 and agreed to merge this pending an addition from @bparth24 and/or confirmation of no additional schema changes being needed. |
@dlongley cc: @msporny @BigBlueHat PR #499 created to address this comment and for potential changes: - #495 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, as elsewhere.
@bparth24 Thank you for the PR! Please try to rebase this PR to do the following:
We should also give you rights to this repo so you don't have to fork -- when that happens, I can't fix up issues like the above, which just slows down the merge process. |
Noted all the comments. I will rebase this PR. I will certainly keep all comments in mind for future PRs. Thank you for the direction. Yes, I got access rights to the W3C-CCG repo. |
This addresses issue w3c-ccg#422 by clarifying how the /credentials/issue endpoint handles credentials with existing proofs. The changes include: - Enhanced documentation explaining three configuration-based behaviors: proof sets, proof chains, and error handling - Updated schema definitions in Credential.yml for proof property - Added optional proofId and previousProof properties to IssueCredentialOptions.yml The issuer instance configuration now determines how existing proofs are processed when issuing credentials. Co-authored-by: Ted Thibodeau Jr <[email protected]> Co-authored-by: Dave Longley <[email protected]> Update schema for proof property description
477d654
to
975a614
Compare
I rebased it. |
Overtaken by PR #503, closing. |
This PR addresses #422 by clarifying how the
/credentials/issue
endpoint handles credentials with existing proofs as agreed upon in the 2025-05-27 call.📋 Changes Made
Enhanced Issue Credential section to document three configuration-based behaviors:
Clarified instance configuration determines proof processing behavior
🔧 Files Changed
index.html
- Updated "Issue Credential" section documentation🤔 Reviewer Input Requested
Potential changes:
components/Credential.yml
file - enhanceUnsecuredCredential
proof property description toAn optional proof or array of proofs for credentials that are secured using proof sets or chains. When present, the issuer instance configuration determines how these existing proofs are processed (appended to create proof sets/chains, or trigger an error).
components/IssueCredentialOptions.yml
- add optionalproofId
andpreviousProof
propertiesissuer.yml
file - enhance endpoint description for proof handling@msporny @dlongley
Please review this documentation approach first and guide me if the schema enhancements are needed to resolve issue #422.
Preview | Diff