Skip to content

chore: renames button sign in experimental prefix #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: renames button sign in experimental prefix #2718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/components/navigation/Navbar/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ function Navbar({
NavbarRow,
NavbarButtons,
IconButton,
_experimentalButtonSignIn: ButtonSignIn,
__experimentalButtonSignIn: ButtonSignIn,
} = useOverrideComponents<'Navbar'>()
const scrollDirection = useScrollDirection()
const { openNavbar, navbar: displayNavbar } = useUI()
Expand Down
6 changes: 3 additions & 3 deletions packages/core/src/components/navigation/NavbarSlider/NavbarSlider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import { useFadeEffect, useUI } from '@faststore/ui'
import { Suspense } from 'react'

import NavbarLinks from 'src/components/navigation/NavbarLinks'
import { ButtonSignInFallback } from 'src/components/ui/Button'
import Link from 'src/components/ui/Link'
import NavbarLinks from 'src/components/navigation/NavbarLinks'
import Logo from 'src/components/ui/Logo'

import type { NavbarProps } from '../Navbar'

import styles from './section.module.scss'
import { useOverrideComponents } from 'src/sdk/overrides/OverrideContext'
import styles from './section.module.scss'

interface NavbarSliderProps {
logo: NavbarProps['logo']
Expand All @@ -31,7 +31,7 @@ function NavbarSlider({
NavbarSliderHeader,
NavbarSliderContent,
NavbarSliderFooter,
_experimentalButtonSignIn: ButtonSignIn,
__experimentalButtonSignIn: ButtonSignIn,
} = useOverrideComponents<'Navbar'>()

const { closeNavbar } = useUI()
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/components/sections/Navbar/DefaultComponents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,5 @@ export const NavbarDefaultComponents = {
NavbarRow: UINavbarRow,
NavbarButtons: UINavbarButtons,
IconButton: UIIconButton,
_experimentalButtonSignIn: ButtonSignIn,
__experimentalButtonSignIn: ButtonSignIn,
} as const
24 changes: 12 additions & 12 deletions packages/core/src/typings/overrides.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { PropsWithChildren } from 'react'
import type {
AlertProps,
BannerTextContentProps,
Expand Down Expand Up @@ -26,40 +25,41 @@ import type {
NavbarSliderFooterProps,
NavbarSliderHeaderProps,
NavbarSliderProps,
NewsletterProps,
NewsletterAddendumProps,
NewsletterContentProps,
NewsletterFormProps,
NewsletterHeaderProps,
NewsletterProps,
ProductPriceProps,
ProductShelfProps,
ProductTitleProps,
QuantitySelectorProps,
RegionBarProps,
ShippingSimulationProps,
SkeletonProps,
SkuSelectorProps,
SKUMatrixProps,
SKUMatrixTriggerProps,
SKUMatrixSidebarProps,
SKUMatrixTriggerProps,
SkuSelectorProps,
} from '@faststore/ui'
import type { PropsWithChildren } from 'react'

import type {
ComponentOverrideDefinition,
SectionOverrideDefinitionV1,
} from './overridesDefinition'
import type Alert from '../components/sections/Alert'
import type Breadcrumb from '../components/sections/Breadcrumb'
import type BannerText from '../components/sections/BannerText'
import type Breadcrumb from '../components/sections/Breadcrumb'
import type CrossSellingShelf from '../components/sections/CrossSellingShelf'
import type EmptyState from '../components/sections/EmptyState'
import type Hero from '../components/sections/Hero'
import type ProductShelf from '../components/sections/ProductShelf'
import type ProductDetails from '../components/sections/ProductDetails'
import type Navbar from '../components/sections/Navbar'
import type Newsletter from '../components/sections/Newsletter'
import type ProductDetails from '../components/sections/ProductDetails'
import type ProductGallery from '../components/sections/ProductGallery'
import type ProductShelf from '../components/sections/ProductShelf'
import type RegionBar from '../components/sections/RegionBar'
import type {
ComponentOverrideDefinition,
SectionOverrideDefinitionV1,
} from './overridesDefinition'

export type SectionOverride = {
[K in keyof SectionsOverrides]: SectionOverrideDefinitionV1<K>
Expand Down Expand Up @@ -198,7 +198,7 @@ export type SectionsOverrides = {
IconButtonProps,
Omit<IconButtonProps, 'onClick'>
>
_experimentalButtonSignIn: ComponentOverrideDefinition<any, any>
__experimentalButtonSignIn: ComponentOverrideDefinition<any, any>
}
}
Newsletter: {
Expand Down
Loading