Skip to content

chore: renames button sign in experimental prefix #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: renames button sign in experimental prefix #2718

wants to merge 1 commit into from

Conversation

hellofanny
Copy link
Contributor

What's the purpose of this pull request?

  • Fixing a small typo issue, it should be __experimentalButtonSignIn instead of _experimentalButtonSignIn (an _ missing)
  • I believe this override is not being used by clients so far, so we can update it now to prevent breaking changes in the future 🙇 (at least didn't find any mention in vtex-sites | can't guarantee in the other repos)
    cc: @ataideverton

@hellofanny hellofanny marked this pull request as ready for review March 10, 2025 23:29
@hellofanny hellofanny requested a review from a team as a code owner March 10, 2025 23:29
@hellofanny hellofanny requested review from eduardoformiga and lariciamota and removed request for a team March 10, 2025 23:29
@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@eduardoformiga eduardoformiga removed their request for review April 16, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lariciamota lariciamota Awaiting requested review from lariciamota lariciamota is a code owner automatically assigned from vtex/faststore

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hellofanny