Fix a panic in the capacity plugin caused by uninitialized realCapability fields in newQueueAttr`

[dafu-wu]

What type of PR is this?

/bug

What this PR does / why we need it:

This PR initializes the realCapability fields in the newQueueAttr function.
Without this initialization, these fields could remain nil, leading to runtime panics (e.g., nil pointer dereference in queueAttr.Clone() when the capacity plugin handles queue resources).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

• The bug is triggered when hierarchical queues have inconsistent resource specifications between parent and child queues.
• The uninitialized fields caused queueAttr.Clone() to dereference a nil Resource.
• This PR ensures safe initialization to avoid such panics.

Does this PR introduce a user-facing change?

Fix a panic in the capacity plugin caused by uninitialized realCapability` fields in `newQueueAttr`.

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/scheduler/plugins/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @dafu-wu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a stability issue within the scheduler's capacity plugin. By ensuring that a specific resource capability field is properly initialized, it prevents application crashes that could occur due to unhandled null values during resource cloning operations, thereby enhancing the robustness of the queue management system.

Highlights

• Bug Fix: Nil Pointer Dereference: This PR resolves a critical bug where the realCapability field in newQueueAttr was not initialized, leading to potential runtime panics (nil pointer dereference) when queueAttr.Clone() was called, especially with hierarchical queues and inconsistent resource specifications.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a critical bug that could cause a panic due to a nil pointer dereference in the capacity plugin. The fix involves initializing the realCapability field within the newQueueAttr function, which is the correct approach to prevent queueAttr.Clone() from failing when hierarchical queue validation does not complete successfully. The change is clean, effective, and also improves code formatting by aligning struct fields. This is a good fix.

[dafu-wu]

@Monokaix can you help review it when you are available?

[hajnalmt]

Hello,
@Monokaix and @JesseStutler I encountered this issue on my production cluster.
This problem appears to be a duplicate of a previously PR-ed one, but this PR provides a more detailed description and the DCO is signed. (without reproduction steps though). So I made an actual issue with a detailed analysis and clear reproduction steps:

🔗 PR: volcano-sh/volcano#4558
🔍 Issue with analysis and reproduction steps: volcano-sh/volcano#4673

Given the impact, this should be prioritzed I think as soon as possible.