🌱 Patch device spec with data from PVCs #1258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palnabarun
force-pushed
the
feature/implement-vmCreateGenConfigSpecImagePVCDataSourceRefs
branch
from
bffc97f to
4bae3eb
Compare
This commit implements the vmCreateGenConfigSpecImagePVCDataSourceRefs
method as part of the AllDisksArePVCs initiative.
For each of the disks in createArgs.ConfigSpec, the
following is done:
1. Iterates over spec.volumes and looks for an entry with an
unmanagedVolumeSource with a type of "FromImage" and name set to
the value that identifies the current disk. If no such entry exists,
then continues to the next disk.
3. Gets the referred PVC. If no such PVC exists, then an error is thrown
indicating the PVC for the specified claim is missing and VM creation
may not proceed.
4. Gets the PVC's specified storage class and requested capacity.
a. Updates the disk device's specified storage class using the value
from the PVC.
b. Updates the disk device's specified capacity using the value from
the PVC *if* it is larger than the disk's current requested size.
Signed-off-by: Nabarun Pal <[email protected]>
palnabarun
force-pushed
the
feature/implement-vmCreateGenConfigSpecImagePVCDataSourceRefs
branch
from
4bae3eb to
e0d78da
Compare
Minimum allowed line rate is |
bryanv
reviewed
Oct 22, 2025
| storageClassName := pvc.Spec.StorageClassName | ||
|
|
||
| if storageClassName == nil || | ||
| storageClassToPolicyID == nil || |
There was a problem hiding this comment.
Don't need nil check
Consider assign profileId var here so it is clear that's what's used later one
| Name: claimName, | ||
| } | ||
|
|
||
| if err := vs.k8sClient.Get(vmCtx, key, pvc); err != nil { |
There was a problem hiding this comment.
A todo for later is that we'll later fetch the PVCs for placement that we should consolidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This commit implements the vmCreateGenConfigSpecImagePVCDataSourceRefs method as part of the AllDisksArePVCs initiative.
For each of the disks in createArgs.ConfigSpec, the following is done:
Iterates over spec.volumes and looks for an entry with an unmanagedVolumeSource with a type of "FromImage" and name set to the value that identifies the current disk. If no such entry exists, then continues to the next disk.
Gets the referred PVC. If no such PVC exists, then an error is thrown indicating the PVC for the specified claim is missing and VM creation may not proceed.
Gets the PVC's specified storage class and requested capacity. a. Updates the disk device's specified storage class using the value from the PVC. b. Updates the disk device's specified capacity using the value from the PVC if it is larger than the disk's current requested size.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: