🌱 Patch device spec with data from PVCs

This commit implements the vmCreateGenConfigSpecImagePVCDataSourceRefs
method as part of the AllDisksArePVCs initiative.

For each of the disks in createArgs.ConfigSpec, the
following is done:

1. Iterates over spec.volumes and looks for an entry with an
   unmanagedVolumeSource with a type of "FromImage" and name set to
   the value that identifies the current disk. If no such entry exists,
   then continues to the next disk.

3. Gets the referred PVC. If no such PVC exists, then an error is thrown
   indicating the PVC for the specified claim is missing and VM creation
   may not proceed.

4. Gets the PVC's specified storage class and requested capacity.
   a. Updates the disk device's specified storage class using the value
      from the PVC.
   b. Updates the disk device's specified capacity using the value from
      the PVC *if* it is larger than the disk's current requested size.

Signed-off-by: Nabarun Pal <[email protected]>

Author: palnabarun

pkg/providers/vsphere/vmprovider_vm.go

@@ -2456,47 +2456,142 @@ func (vs *vSphereVMProvider) vmCreateGenConfigSpecImagePVCDataSourceRefs(
 	vmCtx pkgctx.VirtualMachineContext,
 	createArgs *VMCreateArgs) error {
 
-	_, _ = vmCtx, createArgs // Remove once args are used.
+	if createArgs.ConfigSpec.DeviceChange == nil {
+		return nil
+	}
 
-	// TODO(AllDisksArePVCs)
-	//
-	// Implement this function. For example, for each of the disks in
-	// createArgs.ConfigSpec, do the following:
-	//
-	// 1. Iterate over spec.volumes and look for an entry with an
-	//    unmanagedVolumeSource with a type of "FromImage" and name set to
-	//    the value that identifies the current disk (the logic for
-	//    deriving this name is located in the UpdateVmiWithOVF and
-	//    UpdateVmiWithVirtualMachine functions in the file
-	//    pkg/providers/vsphere/contentlibrary/content_library_utils.go).
-	//
-	// 2. If no such entry exists, then continue to the next iteration of the
-	//    loop.
-	//
-	// 3. Use the k8s client's Get function (do not use CreateOrPatch)
-	//    to see if a PersistentVolumeClaim object already exists for
-	//    this disk. The name of the PersistentVolumeClaim object should
-	//    be what was specified in the field
-	//    spec.volumes[].persistentVolumeClaim.claimName from the prior
-	//    step.
-	//
-	//    If no such entry exists, then return an error indicating the PVC for
-	//    the specified claim is missing and VM creation may not proceed.
-	//
-	// 4. Get the PVC's specified storage class and requested capacity.
-	//
-	//    The PVC *may* specify a different encryption class from the VM, but it
-	//    is probably too much work to handle multiple encryption classes in our
-	//    BYOK reconciler at this point. We will allow the PVC to be recrypted
-	//    by CSI *after* the VM is created and the disk is turned into a PVC.
-	//
-	//    Update the disk device's specified storage class using the value from
-	//    the PVC. Update the disk device's specified capacity using the value
-	//    from the PVC *if* it is larger than the disk's current requested size.
-	//
-	// That should be it! We are not actually registering these disks as PVCs
-	// at this point. That happens in the VM's update workflow later. For now
-	// we just need the information about these disks *from* the PVCs.
+	// lookup map to avoid iterating over the volumes for each disk
+	unmanagedVolumeClaimsFromImage := make(map[string]vmopv1.VirtualMachineVolume)
+	for _, vol := range vmCtx.VM.Spec.Volumes {
+		if vol.PersistentVolumeClaim == nil {
+			continue
+		}
+
+		unmanagedVolumeClaim := vol.PersistentVolumeClaim.UnmanagedVolumeClaim
+		if unmanagedVolumeClaim == nil {
+			continue
+		}
+
+		if unmanagedVolumeClaim.Type != vmopv1.UnmanagedVolumeClaimVolumeTypeFromImage {
+			continue
+		}
+
+		unmanagedVolumeClaimsFromImage[unmanagedVolumeClaim.Name] = vol
+	}
+
+	var errs []error
+
+	for _, deviceChange := range createArgs.ConfigSpec.DeviceChange {
+		deviceSpec := deviceChange.GetVirtualDeviceConfigSpec()
+		if deviceSpec == nil {
+			continue
+		}
+
+		disk, ok := deviceSpec.Device.(*vimtypes.VirtualDisk)
+		if !ok {
+			continue
+		}
+
+		var diskName string
+
+		// TODO(future): Deduplicate this logic as similar is
+		// also there in content_library_utils.go
+		switch tb := disk.Backing.(type) {
+		case *vimtypes.VirtualDiskSeSparseBackingInfo:
+			diskName = strings.TrimSuffix(path.Base(tb.FileName), path.Ext(tb.FileName))
+		case *vimtypes.VirtualDiskSparseVer1BackingInfo:
+			diskName = strings.TrimSuffix(path.Base(tb.FileName), path.Ext(tb.FileName))
+		case *vimtypes.VirtualDiskSparseVer2BackingInfo:
+			diskName = strings.TrimSuffix(path.Base(tb.FileName), path.Ext(tb.FileName))
+		case *vimtypes.VirtualDiskFlatVer1BackingInfo:
+			diskName = strings.TrimSuffix(path.Base(tb.FileName), path.Ext(tb.FileName))
+		case *vimtypes.VirtualDiskFlatVer2BackingInfo:
+			diskName = strings.TrimSuffix(path.Base(tb.FileName), path.Ext(tb.FileName))
+		case *vimtypes.VirtualDiskLocalPMemBackingInfo:
+			diskName = strings.TrimSuffix(path.Base(tb.FileName), path.Ext(tb.FileName))
+		case *vimtypes.VirtualDiskRawDiskMappingVer1BackingInfo:
+			diskName = strings.TrimSuffix(path.Base(tb.FileName), path.Ext(tb.FileName))
+		case *vimtypes.VirtualDiskRawDiskVer2BackingInfo:
+			diskName = strings.TrimSuffix(path.Base(tb.DescriptorFileName), path.Ext(tb.DescriptorFileName))
+		case *vimtypes.VirtualDiskPartitionedRawDiskVer2BackingInfo:
+			diskName = strings.TrimSuffix(path.Base(tb.DescriptorFileName), path.Ext(tb.DescriptorFileName))
+		default:
+			if di := disk.DeviceInfo; di != nil {
+				if d := di.GetDescription(); d != nil {
+					diskName = d.Label
+				}
+			}
+		}
+
+		volume, ok := unmanagedVolumeClaimsFromImage[diskName]
+		if !ok {
+			// there's no claim corresponding to the disk, process further
+			continue
+		}
+
+		pvc := &corev1.PersistentVolumeClaim{}
+		key := ctrlclient.ObjectKey{
+			Namespace: vmCtx.VM.Namespace,
+			Name:      volume.PersistentVolumeClaim.ClaimName,
+		}
+		if err := vs.k8sClient.Get(vmCtx, key, pvc); err != nil {
+			if apierrors.IsNotFound(err) {
+				errs = append(errs, fmt.Errorf(
+					"pvc %s/%s not found for the specified claim %s",
+					key.Namespace, key.Name, diskName,
+				))
+			}
+
+			errs = append(errs, fmt.Errorf(
+				"failed to get pvc %s/%s for the specified claim %s: %w",
+				key.Namespace, key.Name, diskName, err,
+			))
+
+			// process the next disk as this one can't be processed further
+			continue
+		}
+
+		// Update disk device with PVC information
+		// - Set the profile based on the PVC's storage class
+		// - Adjust disk size if PVC requests more than image disk size
+		//
+		// TODO: Does the UUID need to be set as well?
+		storageClassName := pvc.Spec.StorageClassName
+		storageClassToPolicyID := createArgs.Storage.StorageClassToPolicyID
+
+		if storageClassName == nil ||
+			storageClassToPolicyID == nil ||
+			storageClassToPolicyID[*storageClassName] == "" {
+
+			errs = append(errs, fmt.Errorf(
+				"pvc %s/%s has no storage class or no Policy IDmapping for the storage class",
+				key.Namespace, key.Name),
+			)
+
+			continue
+		}
+
+		deviceSpec.Profile = []vimtypes.BaseVirtualMachineProfileSpec{
+			&vimtypes.VirtualMachineDefinedProfileSpec{
+				ProfileId: storageClassToPolicyID[*storageClassName],
+			},
+		}
+
+		if pvcCapacity, ok := pvc.Spec.Resources.Requests[corev1.ResourceStorage]; ok && !pvcCapacity.IsZero() {
+			// TODO: Verify this again
+			pvcSizeBytes := pvcCapacity.Value()
+
+			diskSizeBytes := disk.CapacityInBytes
+			if pvcSizeBytes > diskSizeBytes {
+				disk.CapacityInBytes = pvcSizeBytes
+				disk.CapacityInKB = pvcSizeBytes / 1024
+			}
+		}
+	}
+
+	if len(errs) > 0 {
+		return apierrorsutil.NewAggregate(errs)
+	}
 
 	return nil
 }