Skip to content

Conversation

npentrel
Copy link
Contributor

@npentrel npentrel commented Sep 2, 2025

No description provided.

@npentrel npentrel changed the title DOCS-3374: Add golang code samples DOCS-3374: Add golang fleet code samples Sep 2, 2025
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Sep 2, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 2, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 2, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 2, 2025
@npentrel npentrel requested a review from njooma September 2, 2025 11:42
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 2, 2025
@npentrel
Copy link
Contributor Author

npentrel commented Sep 8, 2025

@njoonaar you the right person to approve this?

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 16, 2025
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments (no need to re-request review) otherwise lgtm. I didn't test the code samples but I assume you did!

Comment on lines +914 to +917
//
// [UpdateOrganizationInviteAuthorizations method docs]: https://docs.viam.com/dev/reference/apis/fleet/#updateorganizationinviteauthorizations
//
//nolint:lll
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this isn't necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link makes the line too long and there is no way to split the link across multiple lines

//
// For more information, see the [UpdateRobotMetadata method docs].
//
// [UpdateRobotMetadata method docs]: https://docs.viam.com/dev/reference/apis/fleet/#updatemetadata
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be https://docs.viam.com/dev/reference/apis/fleet/#updaterobotmetadata instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

//
// For more information, see the [UpdateRobotPartMetadata method docs].
//
// [UpdateRobotPartMetadata method docs]: https://docs.viam.com/dev/reference/apis/fleet/#updatemetadata
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this url end with #updaterobotpartmetadata?

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 16, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 16, 2025
@npentrel npentrel merged commit 404ea44 into main Sep 17, 2025
18 checks passed
@npentrel npentrel deleted the DOCS-3374 branch September 17, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants