-
Notifications
You must be signed in to change notification settings - Fork 124
DOCS-3374: Add golang fleet code samples #5247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@njoonaar you the right person to approve this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small comments (no need to re-request review) otherwise lgtm. I didn't test the code samples but I assume you did!
// | ||
// [UpdateOrganizationInviteAuthorizations method docs]: https://docs.viam.com/dev/reference/apis/fleet/#updateorganizationinviteauthorizations | ||
// | ||
//nolint:lll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine this isn't necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link makes the line too long and there is no way to split the link across multiple lines
app/app_client.go
Outdated
// | ||
// For more information, see the [UpdateRobotMetadata method docs]. | ||
// | ||
// [UpdateRobotMetadata method docs]: https://docs.viam.com/dev/reference/apis/fleet/#updatemetadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be https://docs.viam.com/dev/reference/apis/fleet/#updaterobotmetadata
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
app/app_client.go
Outdated
// | ||
// For more information, see the [UpdateRobotPartMetadata method docs]. | ||
// | ||
// [UpdateRobotPartMetadata method docs]: https://docs.viam.com/dev/reference/apis/fleet/#updatemetadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this url end with #updaterobotpartmetadata
?
No description provided.