Skip to content

fix: Fixed incorrect error for length check in ratelimits section during creating a key #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Fixed incorrect error for length check in ratelimits section during creating a key #4112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
628d258
fixed incorrect name input error for length check in ratelimit section
Akhileshait Oct 18, 2025
90339ed
Merge branch 'main' of https://github.com/Akhileshait/unkey into fix-…
Akhileshait Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...hboard/app/(app)/[workspaceSlug]/apis/[apiId]/_components/create-key/create-key.schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export const ratelimitItemSchema = z.object({
id: z.string().nullish(), // Will be used only for updating case
name: z
.string()
.min(3, { message: "Name is required" })
.min(3, { message: "Name is required and should have at least 3 characters" })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akhileshait

CleanShot 2025-10-20 at 10 39 35 The same thing applies to the ratelimit -> name section.

Please adjust it there too

.max(256, { message: "Name cannot exceed 256 characters" }),
refillInterval: z.coerce
.number({
Expand Down
Loading