-
Notifications
You must be signed in to change notification settings - Fork 584
fix: Fixed incorrect error for length check in ratelimits section during creating a key #4112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Fixed incorrect error for length check in ratelimits section during creating a key #4112
Conversation
|
@Akhileshait is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions for pull request titles! 🙏 |
📝 WalkthroughWalkthroughUpdated the validation error message for the name field in the API key creation schema from "Name is required" to "Name is required and should have at least 3 characters" to accurately reflect the minimum length requirement during validation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Hi @chronark @perkinsjr Please review this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
What does this PR do?
Fixes #4089
This PR fixed Incorrect error which is displayed when creating a key and adding name in input field which shows incorrect error that is "Name is required".
Performance Impact:
Implementation:
Updated Error Message in ratelimit Item Schema from "Name is required" to "Name is required and should have at least 3 characters".
Type of change
How should this be tested?
Unit Tests
Checklist
Required
pnpm build
pnpm fmt
console.logs
git pull origin main