CLDR-14409 Make cldr-apps-webdriver a main app, not a test #4800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Remove AppTest.java -Move other java files from test to main -Update Dockerfile, README.md, and pom.xml -Avoid some NullPointerExceptions in SurveyDriverCredentials.java if properties are not defined, by checking for null before calling toString -Define PROPS_TIME_OUT_SECONDS_KEY consistently with other keys -Change the name cldr-apps-webdriver to CLDR Apps Webdriver, for consistency with cldr-apps, cldr-code -Fix comment for location of surveydriver.properties, now expected directly inside cldr-apps-webdriver directory -Add skipIfEmpty for maven-jar-plugin, maven-install-plugin, and maven-deploy-plugin
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Remove AppTest.java
-Move other java files from test to main
-Update Dockerfile, README.md, and pom.xml
-Avoid some NullPointerExceptions in SurveyDriverCredentials.java if properties are not defined, by checking for null before calling toString
-Define PROPS_TIME_OUT_SECONDS_KEY consistently with other keys
-Change the name cldr-apps-webdriver to CLDR Apps Webdriver, for consistency with cldr-apps, cldr-code
-Fix comment for location of surveydriver.properties, now expected directly inside cldr-apps-webdriver directory
-Add skipIfEmpty for maven-jar-plugin, maven-install-plugin, and maven-deploy-plugin
CLDR-14409
ALLOW_MANY_COMMITS=true