CLDR-14409 Make cldr-apps-webdriver a project module; minor fixes #4736

btangmu · 2025-05-23T19:28:47Z

-Add cldr-apps-webdriver as a module in tools/pom.xml, so it can be debugged in IntelliJ with right-click, Debug All Tests

-Fix comment for location of surveydriver.properties, now expected directly inside cldr-apps-webdriver directory

-Avoid some NullPointerExceptions in SurveyDriverCredentials.java if properties are not defined, by checking for null before calling toString

-Define PROPS_TIME_OUT_SECONDS_KEY consistently with other keys

-In pom.xml, change the name cldr-apps-webdriver to CLDR Apps Webdriver, for consistency with cldr-apps, cldr-code

-In pom.xml, add skipIfEmpty for maven-jar-plugin, maven-install-plugin, and maven-deploy-plugin

-In pom.xml, specify execution goal test-jar to prevent error: ... packaging for this project did not assign a file ...

CLDR-14409

This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-Add cldr-apps-webdriver as a module in tools/pom.xml, so it can be debugged in IntelliJ with right-click, Debug All Tests -Fix comment for location of surveydriver.properties, now expected directly inside cldr-apps-webdriver directory -Avoid some NullPointerExceptions in SurveyDriverCredentials.java if properties are not defined, by checking for null before calling toString -Define PROPS_TIME_OUT_SECONDS_KEY consistently with other keys

-Change the name cldr-apps-webdriver to CLDR Apps Webdriver, for consistency with cldr-apps, cldr-code -Add skipIfEmpty for maven-jar-plugin, maven-install-plugin, and maven-deploy-plugin -Specify execution goal test-jar to prevent error: ... packaging for this project did not assign a file ...

srl295

Looks great!

btangmu · 2025-05-26T16:27:45Z

@srl295 Before merging this, I'm looking at the failures. "cldr-mvn / build (pull_request)Failing after 22m" links to a log including:

[INFO] Running org.unicode.cldr.surveydriver.AppTest
While reading surveydriver.properties java.io.FileNotFoundException: surveydriver.properties (No such file or directory)
java.io.FileNotFoundException: surveydriver.properties (No such file or directory)

Then, "cldr-mvn / Docker test cldr-apps ... Failing after 3m" links to a log including:

SurveyDriverDashboard.test i = 0
...
org.openqa.selenium.StaleElementReferenceException: 
stale element reference: stale element not found in the current frame

Looking at other PRs, there are different failures, so seemingly surveydriver.properties is found sometimes but not always. The inconsistencies are puzzling. For PR 4718, there is:

❌ Test failed, maybe timed out, waiting for id DashboardScroller to exist for http://cldr-apps:9080/cldr-apps/v#/cs//

-Added surveydriver.properties is identical to surveydriver-docker.properties

btangmu · 2025-05-26T17:49:19Z

Actually the FileNotFoundException for surveydriver.properties was blocking this PR. That failure was in the required cldr-mvn / build, not in the currently optional cldr-mvn / Docker test.

The 3rd commit adds surveydriver.properties. It's not clear though whether that should be necessary. Dockerfile has:

COPY surveydriver-docker.properties /workarea/surveydriver.properties

Does SurveyDriverCredentials.java look for it in /workarea/?

InputStream stream = new FileInputStream(PROPS_FILENAME)

Testing without Docker that means it's looked for at tools/cldr-apps-webdriver/surveydriver.properties...

btangmu · 2025-05-26T18:09:18Z

After the 3rd commit, the good news is we don't get "FileNotFoundException: surveydriver.properties"; the bad news is:

 org.openqa.selenium.SessionNotCreatedException: 
Could not start a new session. Possible causes are invalid address of the remote server or browser start-up failure. 
Host info: host: 'pkrvmf6wy0o8zjz', ip: '10.1.1.31'
Build info: version: '4.32.0', revision: 'd17c8aa950'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.11.0-1014-azure', java.version: '11.0.27'
Driver info: org.openqa.selenium.remote.RemoteWebDriver
Command: [null, newSession {capabilities=[Capabilities {browserName: chrome, goog:chromeOptions: {args: [], extensions: []}, goog:loggingPrefs: org.openqa.selenium.logging...}]}]
Capabilities {browserName: chrome, goog:chromeOptions: {args: [], extensions: []}, goog:loggingPrefs: org.openqa.selenium.logging...}
	at org.unicode.cldr.surveydriver.AppTest.shouldDrive(AppTest.java:8)
Caused by: java.io.UncheckedIOException: java.net.ConnectException
Caused by: java.net.ConnectException
Caused by: java.net.ConnectException
Caused by: java.nio.channels.UnresolvedAddressException
[INFO] 
[INFO] Results:
[INFO] 
Error:  Errors: 
Error:    AppTest.shouldDrive:8 » SessionNotCreated Could not start a new session. Possi...

btangmu · 2025-05-27T02:26:32Z

I suspect that the webdriver test should be inhibited during the required cldr-mvn / build (pull_request) and only enabled in cldr-mvn / Docker test cldr-apps (pull_request); the latter is currently not required to pass.

Maybe making cldr-apps-webdriver a project module accounts for its test becoming part of cldr-mvn / build (pull_request)...

srl295 · 2025-05-27T03:03:07Z

it's a test, so it's trying to test it. maybe unlinking it is better so that it only runs when requested.

…

On Mon, May 26, 2025 at 9:26 PM Tom Bishop ***@***.***> wrote: *btangmu* left a comment (unicode-org/cldr#4736) <#4736 (comment)> I suspect that the webdriver test should be inhibited during the required cldr-mvn / build (pull_request) and only enabled in cldr-mvn / Docker test cldr-apps (pull_request); the latter is currently not required to pass. Maybe making cldr-apps-webdriver a project module accounts for its test becoming part of cldr-mvn / build (pull_request)... — Reply to this email directly, view it on GitHub <#4736 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGQZMZVD4TMME4KIV2GGE33APEO3AVCNFSM6AAAAAB5ZPQHIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJQHEZDSMJUGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

srl295 · 2025-05-27T14:09:12Z

tools/cldr-apps-webdriver/surveydriver.properties

oh! I don't think we actually want this file. WE don't WANT the webdriver to run during mvn test - I would move this back to gitignore.

these values are inappropriate outside of the docker build.

srl295 · 2025-05-27T14:09:39Z

tools/pom.xml

@@ -41,6 +41,7 @@
 	<modules>
 		<module>cldr-code</module>
 		<module>cldr-apps</module>
+		<module>cldr-apps-webdriver</module>


Suggested change

<module>cldr-apps-webdriver</module>



Maybe it's better to leave it detached for now.

srl295 · 2025-05-27T14:10:34Z

...cldr-apps-webdriver/src/test/java/org/unicode/cldr/surveydriver/SurveyDriverCredentials.java

+     * A file should exist: cldr-apps-webdriver/surveydriver.properties -- not in version control;
+     * contains WEBDRIVER_PASSWORD=..., etc.


i'd revert this

srl295 · 2025-05-27T14:13:56Z

public class AppTest {
    @Test
    public void shouldDrive() {
        SurveyDriver.runTests();
    }
}

it looks like AppTest.java has the only test hookage.

If we delete AppTest.java and change SurveyDriver to be a main() application then it could be build as a project module and just explicitly called ( move it out of src/test/java into src/main/java )

srl295 · 2025-05-28T00:39:17Z

Actually the FileNotFoundException for surveydriver.properties was blocking this PR. That failure was in the required cldr-mvn / build, not in the currently optional cldr-mvn / Docker test.

but we do not want to run the test in this situation.

The 3rd commit adds surveydriver.properties. It's not clear though whether that should be necessary. Dockerfile has:

COPY surveydriver-docker.properties /workarea/surveydriver.properties

Does SurveyDriverCredentials.java look for it in /workarea/?

looks for it in the current working directory

InputStream stream = new FileInputStream(PROPS_FILENAME)

Testing without Docker that means it's looked for at tools/cldr-apps-webdriver/surveydriver.properties...

right, the working diretory.

Another option is that we could throw an AssumptionViolatedException if the .properties file is missing - then the webdriver test will just get skipped. However, then the test will 'silently fail' in cases where we want to assert that the test passes.

but i think it might be best to make the webdriver not be a unit test and make it an explicitly run executable- what do you think? that will reach the goal of including it in the project hierarchy - which makes sense as a goal.

srl295 · 2025-05-29T14:47:42Z

@btangmu ok if i make changes to this PR as mentioned? maybe i can make a sub PR , i'll do that

btangmu · 2025-05-29T14:55:15Z

ok if i make changes to this PR as mentioned? maybe i can make a sub PR , i'll do that

Yes, anything you'd like. I'm mostly out of office today. I agree webdriver probably doesn't need to be a "test"

srl295 · 2025-05-29T19:23:00Z

btangmu#179 work in progrss but welcome to merge. i'm not able to push for some reason

CLDR-14409 change webdriver to be a 'main' and not a test

btangmu · 2025-06-10T16:04:26Z

@srl295 I merged your sub-PR. That resulted in a "Commit message for 18c1d60 fails validation" which I guess could be fixed by squashing; I don't know if there's another way to fix it. Also there's a merge conflict on SurveyDriverDashboard.java which I'll look at now...

srl295 · 2025-06-10T16:06:22Z

@srl295 I merged your sub-PR. That resulted in a "Commit message for 18c1d60 fails validation" which I guess could be fixed by squashing; I don't know if there's another way to fix it. Also there's a merge conflict on SurveyDriverDashboard.java which I'll look at now...

It needed to be a rebase merge - you could check it out locally and run "git commit --amend" and then fix it and then force push.

btangmu · 2025-06-10T17:02:15Z

See #4800

btangmu self-assigned this May 23, 2025

btangmu requested a review from srl295 May 23, 2025 21:03

srl295 previously approved these changes May 25, 2025

View reviewed changes

CLDR-14409 Add surveydriver.properties, remove it from .gitignore

37210bb

-Added surveydriver.properties is identical to surveydriver-docker.properties

btangmu dismissed srl295’s stale review via 37210bb May 26, 2025 17:40

srl295 reviewed May 27, 2025

View reviewed changes

CLDR-14409 change webdriver to be a 'main' and not a test

8c6211b

srl295 and others added 2 commits June 6, 2025 13:07

CLDR-14409 fe test: call webdriver as an app and not a test

9cb3756

Merge pull request #179 from codehivetx/t14409_a

18c1d60

CLDR-14409 change webdriver to be a 'main' and not a test

btangmu closed this Jun 10, 2025

	<module>cldr-apps-webdriver</module>
	<!-- <module>cldr-apps-webdriver</module> -->

		* A file should exist: cldr-apps-webdriver/surveydriver.properties -- not in version control;
		* contains WEBDRIVER_PASSWORD=..., etc.

CLDR-14409 Make cldr-apps-webdriver a project module; minor fixes #4736

CLDR-14409 Make cldr-apps-webdriver a project module; minor fixes #4736

Uh oh!

Conversation

btangmu commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srl295 left a comment

Choose a reason for hiding this comment

Uh oh!

btangmu commented May 26, 2025

Uh oh!

btangmu commented May 26, 2025

Uh oh!

btangmu commented May 26, 2025

Uh oh!

btangmu commented May 27, 2025

Uh oh!

srl295 commented May 27, 2025 via email

Uh oh!

srl295 May 27, 2025

Choose a reason for hiding this comment

Uh oh!

srl295 May 27, 2025

Choose a reason for hiding this comment

Uh oh!

srl295 May 27, 2025

Choose a reason for hiding this comment

Uh oh!

srl295 May 27, 2025

Choose a reason for hiding this comment

Uh oh!

srl295 commented May 27, 2025

Uh oh!

srl295 commented May 28, 2025

Uh oh!

srl295 commented May 29, 2025

Uh oh!

btangmu commented May 29, 2025

Uh oh!

srl295 commented May 29, 2025

Uh oh!

btangmu commented Jun 10, 2025

Uh oh!

srl295 commented Jun 10, 2025

Uh oh!

btangmu commented Jun 10, 2025

Uh oh!

Uh oh!

btangmu commented May 23, 2025 •

edited

Loading